Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions about the ranking loss #12

Closed
JerryPW opened this issue Sep 7, 2023 · 2 comments
Closed

Questions about the ranking loss #12

JerryPW opened this issue Sep 7, 2023 · 2 comments
Labels
question Further information is requested

Comments

@JerryPW
Copy link

JerryPW commented Sep 7, 2023

Hi! Thanks for your great job!

However, I'm not quite sure where the ranking loss has been implemented in your code. Is the line 129 in train_llff_dtu.py ? If so, how does this depth loss compatible with the ranking loss illustrated in your essay, and how does the gt_depth information help with the the depth_loss, since distance_mean seems only comes from rendering.

Hoping for your reply soon!

@Wanggcong
Copy link
Owner

Wanggcong commented Sep 7, 2023

Please check the depth loss and the depth loss and the ray sampling. These places are the main code to implement the depth loss.

We also suggest the readers to check the detailed tutorial of SparseNeRF.

Please let me know if this solves your problem.

@Wanggcong Wanggcong added the question Further information is requested label Sep 7, 2023
@Wanggcong
Copy link
Owner

I closed the issue since there is no further question. You might re-open the issue or raise a new issue if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants