Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Titlebar corner radius does not match bottom corners #82

Closed
ErikReider opened this issue Jan 1, 2023 · 10 comments · Fixed by #367
Closed

Titlebar corner radius does not match bottom corners #82

ErikReider opened this issue Jan 1, 2023 · 10 comments · Fixed by #367
Assignees
Labels
bug Something isn't working
Milestone

Comments

@ErikReider
Copy link
Collaborator

This only occurs when the border size becomes large enough to be noticeable. Fixing this will make it a lot easier to fix #64 current issue when using these layouts

Example:
image

@ErikReider ErikReider added the bug Something isn't working label Jan 1, 2023
@WillPower3309
Copy link
Owner

Does the issue exist with titlebars in general or just these layouts? If just the layouts I suspect I can fix it rn

@ErikReider
Copy link
Collaborator Author

With titlebars

@WillPower3309 WillPower3309 self-assigned this Jan 1, 2023
@WillPower3309 WillPower3309 changed the title Stacked and Tabbed layout corner radius does not match bottom corners Titlebar corner radius does not match bottom corners Jan 1, 2023
@WillPower3309
Copy link
Owner

This is actually a pretty complex issue that revolves around a lot of the sway logic assuming that the titlebar height / padding should be constant for all windows. Since we can have per container border thickness, which impacts the per container corner radius, there's going to have to be some refactoring here. I've started looking into it, but there's a lot of things to consider here

@ErikReider
Copy link
Collaborator Author

No rush. It's not a gigantic issue. We can always make the shadow mask conform to how it is now and fix it when this is fixed :)

@WillPower3309 WillPower3309 linked a pull request Jan 9, 2023 that will close this issue
2 tasks
@WillPower3309 WillPower3309 mentioned this issue Jan 17, 2023
4 tasks
@WillPower3309 WillPower3309 added this to the 0.2 milestone Jan 18, 2023
@WillPower3309 WillPower3309 modified the milestones: 0.2, 0.3 Mar 11, 2023
@WillPower3309 WillPower3309 removed this from the 0.3 milestone Apr 7, 2023
@WillPower3309 WillPower3309 added this to the 1.0 milestone Apr 21, 2023
@yadobler
Copy link

yadobler commented Oct 2, 2023

How are things going with this? Currently having the same issue, attached some screenshots if it might help.

  1. the top (titlebar) corners are different thickness
  2. the titlebars have corners regardless of layout, like tabbed layout. This one is weird because the parent tabs are behaving, as seen in this preview, but the tabs below do not. I would assume that the tabs might only misbehave on the left most and right most inner tabs, but even the tabs in between have corners

image

cheers!

@adityavishwakarma69
Copy link

How are things going with this? Currently having the same issue, attached some screenshots if it might help.

  1. the top (titlebar) corners are different thickness
  2. the titlebars have corners regardless of layout, like tabbed layout. This one is weird because the parent tabs are behaving, as seen in this preview, but the tabs below do not. I would assume that the tabs might only misbehave on the left most and right most inner tabs, but even the tabs in between have corners

image

cheers!

this only happens if scaling is not a multiple of 50% try shifting to the nearest multiple of 50% till it gets fixed

@WillPower3309
Copy link
Owner

How are things going with this? Currently having the same issue, attached some screenshots if it might help.

  1. the top (titlebar) corners are different thickness
  2. the titlebars have corners regardless of layout, like tabbed layout. This one is weird because the parent tabs are behaving, as seen in this preview, but the tabs below do not. I would assume that the tabs might only misbehave on the left most and right most inner tabs, but even the tabs in between have corners

image

cheers!

What scale do you have in your config?

@yadobler
Copy link

@WillPower3309 @adityavishwakarma69 oh apologies for the late reply. I've moved to hyprland, so unfortunately I don't know.

I have dug through my old dot files, and I have this:

    output * {
        bg $wallpaper fill
        scale 2
    } 

So I'm guessing it's 200% maybe?

But I'll have to reinstall and tinker with it.

@WillPower3309
Copy link
Owner

@WillPower3309 @adityavishwakarma69 oh apologies for the late reply. I've moved to hyprland, so unfortunately I don't know.

I have dug through my old dot files, and I have this:

    output * {
        bg $wallpaper fill
        scale 2
    } 

So I'm guessing it's 200% maybe?

But I'll have to reinstall and tinker with it.

Thanks for the info! I'll try to reproduce it

@WillPower3309
Copy link
Owner

will be fixed by #367

@WillPower3309 WillPower3309 linked a pull request Jan 1, 2025 that will close this issue
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants