-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pre-built binaries #29
Comments
In the earlier version(maybe 0.1), there were prebuilt binaries instead of building during installation.
So, do we need try to provide prebuilt binaries now? If I have time, I'd like to try, especially node:ffi to see if it works, because webview_deno is using prebuilt binaries with deno's built-in ffi api, that's a very popular project for deno and we should follow it. |
I think it's worth a try 😉 |
Let me briefly describe my situation. I am trying to create an Electron analog, but in a slightly different form - nodejs + webview. I also want to build it with node-sea if possible. And here I ran into this problem: the .node files are “lost” during the build. I tried to package with bpkg, but that makes the build platform-dependent, which I probably don't need to do if I had pre-built binaries. And it would also allow to build an application for 3 different operating systems (Win, Mac, Linux) on one (as it works with the pkg module example). |
TLDR: I decided make pre-build It seems that the packager resolve the relative path of And after thinks for a long time, I decide to keep using Node-API to build And I finally decided not to follow webview-bun and webview-deno to make pre-built |
As far as I remember, .node files are the same .dll and .so, just renamed. I've now come to the point where I'm writing a wrapper for my project that uses wry and tao (tauri libraries) under the hood to create windows for nodejs. And I'm building it using napi-rs. You might find this option suitable for you. |
And about the node sea - yes, I didn't notice that right away. In this case you can use bpkg, it will package .node files in base64 and load them into runtime. But in my case it doesn't work because it requires modification, and it's probably easier to write a plugin for esbuild (I use it in my project), which will put the .node files next to the program executable. |
I propose to add a binary build for the module to save users from unnecessary build steps and make it possible to conveniently work with the package as a dependency in other projects.
UPD Oh wait, I seem to have misunderstood how I'm supposed to interact with the built .node files when including them in my project
UPD2 I think I'm confused, so I'll wait for your opinion on this.
The text was updated successfully, but these errors were encountered: