Skip to content

Commit 32b4b2e

Browse files
authored
Downgrade node 22(.5) unit tests to 22.4 (#63728)
* Downgrade node 22 unit tests to 22.4 until npm/cli#7657 is fixed * try again * Try using a stable name for the tests so that required jobs do not require an update
1 parent 0a7e10d commit 32b4b2e

File tree

2 files changed

+21
-9
lines changed

2 files changed

+21
-9
lines changed

.github/workflows/create-block.yml

+7-3
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,17 @@ concurrency:
1414

1515
jobs:
1616
checks:
17-
name: Checks w/Node.js ${{ matrix.node }} on ${{ matrix.os }}
17+
name: Checks w/Node.js ${{ matrix.node.name }} on ${{ matrix.os }}
1818
runs-on: ${{ matrix.os }}
1919
if: ${{ github.repository == 'WordPress/gutenberg' || github.event_name == 'pull_request' }}
2020
strategy:
2121
fail-fast: false
2222
matrix:
23-
node: ['20', '22']
23+
node:
24+
- name: 20
25+
version: 20
26+
- name: 22
27+
version: 22.4
2428
os: ['macos-latest', 'ubuntu-latest', 'windows-latest']
2529

2630
steps:
@@ -31,7 +35,7 @@ jobs:
3135
- name: Setup Node.js and install dependencies
3236
uses: ./.github/setup-node
3337
with:
34-
node-version: ${{ matrix.node }}
38+
node-version: ${{ matrix.node.version }}
3539

3640
- name: Create block
3741
shell: bash

.github/workflows/unit-test.yml

+14-6
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,17 @@ concurrency:
2121

2222
jobs:
2323
unit-js:
24-
name: JavaScript (Node.js ${{ matrix.node }}) ${{ matrix.shard }}
24+
name: JavaScript (Node.js ${{ matrix.node.name }}) ${{ matrix.shard }}
2525
runs-on: ubuntu-latest
2626
if: ${{ github.repository == 'WordPress/gutenberg' || github.event_name == 'pull_request' }}
2727
strategy:
2828
fail-fast: false
2929
matrix:
30-
node: ['20', '22']
30+
node:
31+
- name: 20
32+
version: 20
33+
- name: 22
34+
version: 22.4
3135
shard: ['1/4', '2/4', '3/4', '4/4']
3236

3337
steps:
@@ -39,7 +43,7 @@ jobs:
3943
- name: Setup Node.js and install dependencies
4044
uses: ./.github/setup-node
4145
with:
42-
node-version: ${{ matrix.node }}
46+
node-version: ${{ matrix.node.version }}
4347

4448
- name: Determine the number of CPU cores
4549
uses: SimenB/github-actions-cpu-cores@97ba232459a8e02ff6121db9362b09661c875ab8 # v2.0.0
@@ -60,13 +64,17 @@ jobs:
6064
--cacheDirectory="$HOME/.jest-cache"
6165
6266
unit-js-date:
63-
name: JavaScript Date Tests (Node.js ${{ matrix.node }})
67+
name: JavaScript Date Tests (Node.js ${{ matrix.node.name }})
6468
runs-on: ubuntu-latest
6569
if: ${{ github.repository == 'WordPress/gutenberg' || github.event_name == 'pull_request' }}
6670
strategy:
6771
fail-fast: false
6872
matrix:
69-
node: ['20', '22']
73+
node:
74+
- name: 20
75+
version: 20
76+
- name: 22
77+
version: 22.4
7078

7179
steps:
7280
- name: Checkout repository
@@ -77,7 +85,7 @@ jobs:
7785
- name: Setup Node.js and install dependencies
7886
uses: ./.github/setup-node
7987
with:
80-
node-version: ${{ matrix.node }}
88+
node-version: ${{ matrix.node.version }}
8189

8290
- name: Determine the number of CPU cores
8391
uses: SimenB/github-actions-cpu-cores@97ba232459a8e02ff6121db9362b09661c875ab8 # v2.0.0

0 commit comments

Comments
 (0)