Adapt reducer and fixes

Author: SantosGuillamot

packages/blocks/src/api/registration.js

@@ -806,9 +806,9 @@ export const registerBlockBindingsSource = ( source ) => {
 
 	/*
 	 * Check if the source has been already registered on the client.
-	 * If the `getValue` property is defined, it could be assumed the source is already registered.
+	 * If the `getValues` property is defined, it could be assumed the source is already registered.
 	 */
-	if ( existingSource?.getValue ) {
+	if ( existingSource?.getValues ) {
 		warning(
 			'Block bindings source "' + name + '" is already registered.'
 		);
@@ -891,7 +891,14 @@ export const registerBlockBindingsSource = ( source ) => {
 		return;
 	}
 
-	return unlock( dispatch( blocksStore ) ).addBlockBindingsSource( source );
+	return unlock( dispatch( blocksStore ) ).addBlockBindingsSource( {
+		name,
+		label,
+		getValues,
+		setValues,
+		getPlaceholder,
+		canUserEditValue,
+	} );
 };
 
 /**

packages/blocks/src/api/test/registration.js

@@ -1616,7 +1616,7 @@ describe( 'blocks', () => {
 			const source = {
 				name: 'core/test-source',
 				label: 'Test Source',
-				getValue: () => 'value',
+				getValues: () => 'value',
 			};
 			registerBlockBindingsSource( source );
 			registerBlockBindingsSource( source );

packages/blocks/src/store/reducer.js

@@ -374,34 +374,22 @@ export function collections( state = {}, action ) {
 export function blockBindingsSources( state = {}, action ) {
 	switch ( action.type ) {
 		case 'ADD_BLOCK_BINDINGS_SOURCE':
-			// Filter the name property, the type property, and the undefined values.
-			const newProperties = Object.fromEntries(
-				Object.entries( action ).filter(
-					( [ key, value ] ) =>
-						value !== undefined && key !== 'name' && key !== 'type'
-				)
-			);
-
 			return {
 				...state,
 				[ action.name ]: {
-					// Keep the existing properties if it has been bootstrapped.
-					...state[ action.name ],
-					// Update with the new properties.
-					...newProperties,
-					canUserEditValue:
-						action.canUserEditValue || ( () => false ),
+					// Don't override the label if it's already set.
+					label: state[ action.name ]?.label || action.label,
+					getValues: action.getValues,
+					setValues: action.setValues,
+					getPlaceholder: action.getPlaceholder,
+					canUserEditValue: action.canUserEditValue,
 				},
 			};
 		case 'ADD_BOOTSTRAPPED_BLOCK_BINDINGS_SOURCE':
 			return {
 				...state,
 				[ action.name ]: {
 					label: action.label,
-					getValues: action.getValues,
-					setValues: action.setValues,
-					getPlaceholder: action.getPlaceholder,
-					canUserEditValue: action.canUserEditValue,
 					usesContext: action.usesContext,
 				},
 			};