Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSE: Featured image block is available when theme support is not declared. #22313

Closed
carolinan opened this issue May 13, 2020 · 2 comments
Closed
Labels
[Block] Image Affects the Image Block [Block] Post Featured Image Affects the Post Featured Image Block [Feature] Themes Questions or issues with incorporating or styling blocks in a theme.

Comments

@carolinan
Copy link
Contributor

Describe the bug
When full site editing is enabled, the featured image block can be selected in the list of available blocks, even if the theme does not add the theme support for featured image.
And without the theme support, there is no input field for adding a featured image.

I am not sure what the plan is, but these things could be considered:

    • To make the featured image available for themes by default, without theme support.
    • Let themes declare support via the global styles JSON settings file.
    • Continue to require theme support by using a functions.php file

-Use the existing input field for featured images
-Use the same input as an image block

To reproduce
Steps to reproduce the behavior:

  1. Enable full site editing
  2. Create a new post or page
  3. Choose to add a new block and search for the featured image.
  4. successfully add the (blank) block.

Expected behavior
There are several options, but with the block available, I expect to be able to also add an image.
I would not mind if the featured image was enabled by default.

Editor version
WordPress version: 5.4.1
Gutenberg: Master, latest commit was: 754c472

Desktop
Windows 10
Chrome version: 81.0.4044.138

@annezazu annezazu added [Block] Image Affects the Image Block [Feature] Full Site Editing [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. labels May 20, 2020
@carolinan carolinan added the [Block] Post Featured Image Affects the Post Featured Image Block label Jun 4, 2020
@aristath
Copy link
Member

Do we even want to keep the featured-image support for FSE themes? Does it make sense to keep it?
Non-FSE themes had to define the theme-support because they were adding the feature image usually without any user interaction. With FSE and users being able to just add the block in their templates I don't think it would make a lot of sense to keep around the theme-support 🤔

@carolinan
Copy link
Contributor Author

The reason why this was a problem was that without the theme support, there was no way to add a featured image.
Now the block itself has the image upload and image selection capability and this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Image Affects the Image Block [Block] Post Featured Image Affects the Post Featured Image Block [Feature] Themes Questions or issues with incorporating or styling blocks in a theme.
Projects
None yet
Development

No branches or pull requests

3 participants