Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline Images: Can't replace image #25909

Open
melchoyce opened this issue Oct 7, 2020 · 2 comments
Open

Inline Images: Can't replace image #25909

melchoyce opened this issue Oct 7, 2020 · 2 comments
Labels
[Block] Image Affects the Image Block [Package] Format library /packages/format-library [Type] Enhancement A suggestion for improvement.

Comments

@melchoyce
Copy link
Contributor

Describe the bug
When you add an inline image, there isn't a way to replace it with a new image.

To reproduce
Steps to reproduce the behavior:

  1. Go to the editor and add some text.
  2. Click on the dropdown arrow and click "Inline image"
  3. Upload or select an image
  4. Click on the image; you can change its size, but not replace the image.

Expected behavior
I expect inline images to have a similar block toolbar as images, or, image settings should be appended to the paragraph/heading toolbars.

Screenshots
image

Editor version (please complete the following information):

  • WordPress version: 5.5.1
  • Does the website has Gutenberg plugin installed, or is it using the block editor that comes by default?: Default

Additional context
This came up while trying to implement a pattern in Twenty Twenty-One: WordPress/twentytwentyone#299

@annezazu annezazu added [Type] Bug An existing feature does not function as intended Needs Testing Needs further testing to be confirmed. [Block] Image Affects the Image Block and removed [Type] Bug An existing feature does not function as intended Needs Testing Needs further testing to be confirmed. labels Oct 13, 2020
@annezazu
Copy link
Contributor

I was able to replicate this with 5.5.1 and Gutenberg 9.1 after chatting with @melchoyce and getting this screenshot showing where the option lives:

image

@Mamaduka
Copy link
Member

It looks like you can replace inline images, but action is just very obscure.

Maybe we can place the "Edit" or "Replace" button in the width popover.

If someone can provide mockups for the new UX, I'll be happy to do the rest.

Screencast

block-editor-replace-inline-image.mp4

@mtias mtias added [Type] Enhancement A suggestion for improvement. and removed [Type] Bug An existing feature does not function as intended labels May 22, 2022
@ellatrix ellatrix added the [Package] Format library /packages/format-library label Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Image Affects the Image Block [Package] Format library /packages/format-library [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

5 participants