Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Main editor region outline does not display when navigating regions #32758

Closed
talldan opened this issue Jun 17, 2021 · 1 comment
Closed

Main editor region outline does not display when navigating regions #32758

talldan opened this issue Jun 17, 2021 · 1 comment
Labels
CSS Styling Related to editor and front end styles, CSS-specific issues. [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). General Interface Parts of the UI which don't fall neatly under other labels. Good First Issue An issue that's suitable for someone looking to contribute for the first time [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed [Type] Bug An existing feature does not function as intended

Comments

@talldan
Copy link
Contributor

talldan commented Jun 17, 2021

Description

When navigating regions, each region is expected to have a blue outline when focused.

This doesn't seem to happen in the post or widget editors due to another element overlapping the region.

Step-by-step reproduction instructions

  1. Use the shortcut for navigating regions (Ctrl+Opt+N on a mac)
  2. Note the blue outline on most regions
  3. Focus the editor region

Expected behaviour

The editor region is outlined when focused (the same as the header, footer, sidebar)

Actual behaviour

The editor region isn't outline when focused

Additional info

The CSS for the regions is here:
https://github.com/WordPress/gutenberg/blob/trunk/packages/components/src/higher-order/navigate-regions/style.scss

It might be possible to use a pseudo-element with a higher z-index to solve the issue.
@talldan talldan added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Good First Issue An issue that's suitable for someone looking to contribute for the first time General Interface Parts of the UI which don't fall neatly under other labels. CSS Styling Related to editor and front end styles, CSS-specific issues. labels Jun 17, 2021
@talldan
Copy link
Contributor Author

talldan commented Jun 17, 2021

Oh, looks like a duplicate of #21717.

@talldan talldan closed this as completed Jun 17, 2021
@talldan talldan added the [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed label Jun 17, 2021
@talldan talldan mentioned this issue Jun 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CSS Styling Related to editor and front end styles, CSS-specific issues. [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). General Interface Parts of the UI which don't fall neatly under other labels. Good First Issue An issue that's suitable for someone looking to contribute for the first time [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@talldan