Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BorderRadiusControl: Improve element alignment #35815

Closed
2 tasks
mirka opened this issue Oct 20, 2021 · 1 comment
Closed
2 tasks

BorderRadiusControl: Improve element alignment #35815

mirka opened this issue Oct 20, 2021 · 1 comment
Labels
CSS Styling Related to editor and front end styles, CSS-specific issues. [Feature] Component System WordPress component system [Package] Block editor /packages/block-editor

Comments

@mirka
Copy link
Member

mirka commented Oct 20, 2021

Follow-up issue after #35646

The Unlink button is currently aligned to flex-start, which is presumably to have it stay put when the corners are all unlinked. This was less noticeable in the previous design, but due to the taller input control it now looks more clearly misaligned in the linked state.

It would probably be better to:

  • Center align the Unlink button with the first row of inputs
  • Add a little more whitespace between the input and the slider

May need to coordinate with related issue #35602

Screenshots

Before (smaller input height)

Border Radius Control before the redesign

After (taller input height)

Border Radius Control, linked corners

Border Radius Control, unlinked corners

@mirka mirka added [Package] Block editor /packages/block-editor CSS Styling Related to editor and front end styles, CSS-specific issues. [Feature] Component System WordPress component system labels Oct 20, 2021
@mirka
Copy link
Member Author

mirka commented Nov 4, 2021

Closing this for now since we won't be doing a blanket upsizing for the UnitControl component. May be resuscitated in the future.

@mirka mirka closed this as completed Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS Styling Related to editor and front end styles, CSS-specific issues. [Feature] Component System WordPress component system [Package] Block editor /packages/block-editor
Projects
None yet
Development

No branches or pull requests

1 participant