Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSE: Link Style Doesn't Match Page Editor Style #43939

Closed
Robertght opened this issue Sep 7, 2022 · 8 comments
Closed

FSE: Link Style Doesn't Match Page Editor Style #43939

Robertght opened this issue Sep 7, 2022 · 8 comments
Labels
Needs Testing Needs further testing to be confirmed. [Status] Needs More Info Follow-up required in order to be actionable.

Comments

@Robertght
Copy link

Robertght commented Sep 7, 2022

Description

Links are underlined in the Site Editor. In the Page editor, links are not underlined. The live view of the site does not underline links unless they are hovered.

Originally reported here: Automattic/themes#6521

Step-by-step reproduction instructions

Add a link to the home page editor. Notice that it is not underlined.
View the home page through the site editor. The link will be underlined.

Screenshots, screen recording, code snippet

image

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@talldan talldan added the Needs Testing Needs further testing to be confirmed. label Sep 8, 2022
@talldan
Copy link
Contributor

talldan commented Sep 8, 2022

@Robertght Would you be able to improve the reproduction steps.

When I tested (adding a link to a paragraph in the page editor), the underline shows up fine:
Screen Shot 2022-09-08 at 10 08 11 am

But I have a feeling I might not be reproducing this as intended. The part I'm not sure about is "Add a link to the home page editor."

@talldan talldan added the [Status] Needs More Info Follow-up required in order to be actionable. label Sep 8, 2022
@Robertght
Copy link
Author

Thank you @talldan !

It looks like this is theme-specific for now.

I noticed the link underline doesn't show up on the frontend as opposed to the Site editor. Is this expected or an issue?
If an issue, should I adjust this report or create a new one?

@talldan
Copy link
Contributor

talldan commented Sep 8, 2022

So the situation is (for a specific theme):

  • Frontend - no underline
  • Page editor - no underline
  • Site editor - underline

Is that correct?

It may be a bug with the theme, but it's hard to say for sure. Is there a theme I can test with?

@Robertght
Copy link
Author

Robertght commented Sep 8, 2022

Correct!

However, the frontend vs Site Editor thing is consistent regardless of the theme.

The one with the page vs site editor has been reported here: Automattic/themes#6521 (Blank Canvas)

@carolinan
Copy link
Contributor

Which block was used to test this? There are many blocks that can have links.
Please test with a theme that has no styling, like Emptytheme, that you can find in the Gutenberg/test folder.

A related navigation block issue was reported here:
#42766

@Robertght
Copy link
Author

Sorry for the delay here @carolinan !

This was a simple paragraph block. I tried testing with the Emptytheme theme, but I got a missing style.css error during instalation

@carolinan
Copy link
Contributor

Empty theme in the Experiments repo is not the same files as in the Gutenberg repository. The experiments repo is not maintained.

@ndiego
Copy link
Member

ndiego commented Sep 27, 2022

This issue was reviewed in today's Editor Bug Scrub. We have been unable to replicate using the latest versions of Gutenberg, WordPress, and the Twenty Twenty-Two theme. Therefore, this seems to be a theme-specific issue, and I am going to close this. If anyone can replicate it in the future, please feel free to reopen this issue with additional information.

@ndiego ndiego closed this as completed Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Testing Needs further testing to be confirmed. [Status] Needs More Info Follow-up required in order to be actionable.
Projects
None yet
Development

No branches or pull requests

4 participants