Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UnitControl: normalize wrapper classnames #45094

Closed
ciampo opened this issue Oct 19, 2022 · 2 comments
Closed

UnitControl: normalize wrapper classnames #45094

ciampo opened this issue Oct 19, 2022 · 2 comments
Assignees
@ciampo @aaronrobertshaw
Labels
[Package] Components /packages/components

Comments

@ciampo
Copy link
Contributor

ciampo commented Oct 19, 2022

As discussed in #41860 (comment), we should try to normalize the way UnitControl applies the className prop to its internal markup — in particular, the general expectation is that className applies to the outer wrapper (which is currently not the case).

This refactor would also include changes to the recently introduced __unstableWrapperClassName prop.

One option that could be worth exploring could be to remove the outer wrapper altogether, which would allow us to simplify the styles with minimal disruption.
@ciampo ciampo added the [Package] Components /packages/components label Oct 19, 2022
@ciampo ciampo mentioned this issue Oct 19, 2022
Merged
@aaronrobertshaw aaronrobertshaw mentioned this issue Oct 20, 2022
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Oct 20, 2022
@aaronrobertshaw
Copy link
Contributor

I have a PR up exploring the removal of the UnitControl's outer wrapper in #45139. Depending on any feedback for it, it might be better to be rolled into #41860

@aaronrobertshaw
Copy link
Contributor

Closing this as complete now that #41860 has been merged.

@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ciampo ciampo

@aaronrobertshaw aaronrobertshaw

Labels
[Package] Components /packages/components
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ciampo @priethor @aaronrobertshaw