Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header text scale is inconsistent and should be standardized. #8373

Closed
kjellr opened this issue Aug 1, 2018 · 5 comments · Fixed by #15393
Closed

Header text scale is inconsistent and should be standardized. #8373

kjellr opened this issue Aug 1, 2018 · 5 comments · Fixed by #15393
Labels
[Block] Classic Affects the Classic Editor Block [Feature] Blocks Overall functionality of blocks [Type] Bug An existing feature does not function as intended

Comments

@kjellr
Copy link
Contributor

kjellr commented Aug 1, 2018

In the Classic Editor block, the header text sizes (and line heights) do not match the header text sizes used in the rest of the editor. These should be identical.

Classic Editor:

screen shot 2018-08-01 at 2 34 06 pm

Gutenberg Header Blocks:

screen shot 2018-08-01 at 2 34 11 pm

@kjellr kjellr added [Type] Bug An existing feature does not function as intended [Feature] Blocks Overall functionality of blocks labels Aug 1, 2018
@kjellr kjellr mentioned this issue Aug 1, 2018
6 tasks
@designsimply
Copy link
Member

Closed #8069 to consolidate here and noting that #8069 makes a case for updating to font sizes that work out to values in pixels without decimals in order to improve consistency between browsers since each may round slightly differently. For example:

h1
2.5em x 16 = 40px

@kjellr kjellr changed the title Classic Block: Header text scale does not match that of the rest of the editor. Header text scale is inconsistent and should be standardized. Aug 1, 2018
@kjellr
Copy link
Contributor Author

kjellr commented Aug 1, 2018

Cool — I've updated the title to make it a bit more broad in that case.

@afercia
Copy link
Contributor

afercia commented Aug 1, 2018

Please notice in #8069 there's some more detailed information that is important to correctly address this issue. Also, avoiding rounding should be considered also for paragraphs, see example and screenshots on #8069 (comment)

@jorgefilipecosta
Copy link
Member

Hi @kjellr it seems like to solution to this is update the classic block styles to match the rest of the editor. Could you confirm if that's the case?

@jorgefilipecosta jorgefilipecosta added the [Block] Classic Affects the Classic Editor Block label Apr 22, 2019
@kjellr
Copy link
Contributor Author

kjellr commented Apr 22, 2019

@jorgefilipecosta Yes, that's a good first step. I think we'd also wanted to address the fraction-of-a-pixel rendering caused by our type scale (as noted in #8069 too), but that can be handled separately.

For now, it's definitely weird that a h2 in the classic block isn't the same size as a h2 outside of it for instance. So fixing that would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Classic Affects the Classic Editor Block [Feature] Blocks Overall functionality of blocks [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants