Skip to content

Commit 9093d5a

Browse files
committed
Fix searchEnable flag was not respected for select-multiple Choices-js#1042
1 parent 0195386 commit 9093d5a

File tree

9 files changed

+8
-14
lines changed

9 files changed

+8
-14
lines changed

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -45,3 +45,4 @@
4545
* Fix `addItemFilter` would allow empty strings as input to be added for items.
4646
* Fix various issues with double escaping when displaying items/choices depending on allowHTML mode.
4747
* Fix `aria-label` for placeholders was set to the string `null`
48+
* Fix `searchEnable` flag was not respected for `select-multiple` [#1042](https://github.com/Choices-js/Choices/issues/1042)

README.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -401,9 +401,9 @@ Pass an array of objects:
401401

402402
**Type:** `Boolean` **Default:** `true`
403403

404-
**Input types affected:** `select-one`
404+
**Input types affected:** `select-one`, `select-multiple`
405405

406-
**Usage:** Whether a search area should be shown. **Note:** Multiple select boxes will _always_ show search areas.
406+
**Usage:** Whether a search area should be shown.
407407

408408
### searchChoices
409409

public/assets/scripts/choices.js

-1
Original file line numberDiff line numberDiff line change
@@ -258,7 +258,6 @@ var Choices = /** @class */function () {
258258
this._isSelectOneElement = this._elementType === constants_1.SELECT_ONE_TYPE;
259259
this._isSelectMultipleElement = this._elementType === constants_1.SELECT_MULTIPLE_TYPE;
260260
this._isSelectElement = this._isSelectOneElement || this._isSelectMultipleElement;
261-
this.config.searchEnabled = this._isSelectMultipleElement || this.config.searchEnabled;
262261
if (!['auto', 'always'].includes("".concat(this.config.renderSelectedChoices))) {
263262
this.config.renderSelectedChoices = 'auto';
264263
}

public/assets/scripts/choices.min.js

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

public/types/src/scripts/choices.d.ts.map

+1-1
Original file line numberDiff line numberDiff line change

public/types/src/scripts/interfaces/options.d.ts

+1-3
Original file line numberDiff line numberDiff line change
@@ -272,9 +272,7 @@ export interface Options {
272272
/**
273273
* Whether a search area should be shown.
274274
*
275-
* @note Multiple select boxes will always show search areas.
276-
*
277-
* **Input types affected:** select-one
275+
* **Input types affected:** select-one, select-multiple
278276
*
279277
* @default true
280278
*/

public/types/src/scripts/interfaces/options.d.ts.map

+1-1
Original file line numberDiff line numberDiff line change

0 commit comments

Comments
 (0)