Skip to content

Commit 71990f3

Browse files
committed
resolving comments
Signed-off-by: Prateeknandle <prateeknandle@gmail.com>
1 parent fd99cda commit 71990f3

File tree

1 file changed

+5
-9
lines changed

1 file changed

+5
-9
lines changed

src/recommendpolicy/recommendPolicy.go

+5-9
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,6 @@ func StopRecommendCronJob() {
129129

130130
// RecommendPolicyMain generates recommended policies from policy-template GH
131131
func RecommendPolicyMain() {
132-
var policy []types.KnoxSystemPolicy
133132

134133
if !isLatest() {
135134
if _, err := DownloadAndUnzipRelease(); err != nil {
@@ -162,26 +161,23 @@ func RecommendPolicyMain() {
162161

163162
for _, ns := range NsNotFilter {
164163
if d.Namespace != ns {
165-
policy = generateHardenPolicy(d.Name, d.Namespace, d.Spec.Template.Labels)
166-
policies = append(policies, policy...)
164+
policies = append(policies, generateHardenPolicy(d.Name, d.Namespace, d.Spec.Template.Labels)...)
167165
}
168166
}
169167
}
170168

171169
for _, r := range replicaSets.Items {
172170
for _, ns := range NsNotFilter {
173171
if r.Namespace != ns && len(r.ObjectMeta.OwnerReferences) == 0 {
174-
policy = generateHardenPolicy(r.Name, r.Namespace, r.Spec.Template.Labels)
175-
policies = append(policies, policy...)
172+
policies = append(policies, generateHardenPolicy(r.Name, r.Namespace, r.Spec.Template.Labels)...)
176173
}
177174
}
178175
}
179176

180-
for _, r := range statefulSets.Items {
177+
for _, s := range statefulSets.Items {
181178
for _, ns := range NsNotFilter {
182-
if r.Namespace != ns {
183-
policy = generateHardenPolicy(r.Name, r.Namespace, r.Spec.Template.Labels)
184-
policies = append(policies, policy...)
179+
if s.Namespace != ns {
180+
policies = append(policies, generateHardenPolicy(s.Name, s.Namespace, s.Spec.Template.Labels)...)
185181
}
186182
}
187183
}

0 commit comments

Comments
 (0)