Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report proper Product value in Windows #11

Open
aivarannamaa opened this issue Jan 29, 2024 · 2 comments
Open

Report proper Product value in Windows #11

aivarannamaa opened this issue Jan 29, 2024 · 2 comments

Comments

@aivarannamaa
Copy link

Currently the Windows procedure enhances reporting of the Inteface field.

Could you also extend your enhancement so that the Product field starts showing proper information?

Or can you give me hints, which part to tweak?
@aivarannamaa
Copy link
Author

A working solution can be found at pyserial/pyserial#725

@aivarannamaa
Copy link
Author

A working solution can be found at pyserial/pyserial#725

The latest version of this PR now also reports interface correctly.

Well, at least it produces the same value as adafruit_board_toolkit / pyserial/pyserial#571. I can't explain why Pyserial with either patch reports the interface of CircuitPython SAMD devices as "CircuitPython CDC control" on Windows, while on macOS adafruit_board_toolkit / pyserial/pyserial#566 reports it as "CircuitPython CDC data".

Anyway, pyserial/pyserial#725 now subsumes pyserial/pyserial#571 and I recommend basing your _list_ports_win32 on this.

@aivarannamaa aivarannamaa mentioned this issue Feb 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aivarannamaa