Skip to content

Commit b609eeb

Browse files
committedMay 6, 2016
Merge pull request Netflix#253 from mlafeldt/rest-event-id
REST API: Add event ID to list of chaos events
2 parents 79f5263 + 7272156 commit b609eeb

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed
 

‎src/main/java/com/netflix/simianarmy/resources/chaos/ChaosMonkeyResource.java

+1
Original file line numberDiff line numberDiff line change
@@ -137,6 +137,7 @@ public Response getChaosEvents(@Context UriInfo uriInfo) throws IOException {
137137
for (Event evt : evts) {
138138
gen.writeStartObject();
139139
gen.writeStringField("monkeyType", evt.monkeyType().name());
140+
gen.writeStringField("eventId", evt.id());
140141
gen.writeStringField("eventType", evt.eventType().name());
141142
gen.writeNumberField("eventTime", evt.eventTime().getTime());
142143
gen.writeStringField("region", evt.region());

‎src/test/java/com/netflix/simianarmy/resources/chaos/TestChaosMonkeyResource.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -202,8 +202,8 @@ private MonkeyRecorder.Event mkEvent(String instance) {
202202
final MonkeyType monkeyType = ChaosMonkey.Type.CHAOS;
203203
final EventType eventType = ChaosMonkey.EventTypes.CHAOS_TERMINATION;
204204
// SUPPRESS CHECKSTYLE MagicNumber
205-
return new BasicRecorderEvent(monkeyType, eventType, "region", "id", 1330538400000L)
206-
.addField("instanceId", instance).addField("groupType", "ASG").addField("groupName", "testGroup");
205+
return new BasicRecorderEvent(monkeyType, eventType, "region", instance, 1330538400000L)
206+
.addField("groupType", "ASG").addField("groupName", "testGroup");
207207
}
208208

209209
public static class MockTestChaosMonkeyContext extends TestChaosMonkeyContext {
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
[{"monkeyType":"CHAOS","eventType":"CHAOS_TERMINATION","eventTime":1330538400000,"region":"region","groupType":"ASG","groupName":"testGroup","instanceId":"i-123456789012345670"},{"monkeyType":"CHAOS","eventType":"CHAOS_TERMINATION","eventTime":1330538400000,"region":"region","groupType":"ASG","groupName":"testGroup","instanceId":"i-123456789012345671"}]
1+
[{"monkeyType":"CHAOS","eventId":"i-123456789012345670","eventType":"CHAOS_TERMINATION","eventTime":1330538400000,"region":"region","groupType":"ASG","groupName":"testGroup"},{"monkeyType":"CHAOS","eventId":"i-123456789012345671","eventType":"CHAOS_TERMINATION","eventTime":1330538400000,"region":"region","groupType":"ASG","groupName":"testGroup"}]

0 commit comments

Comments
 (0)
Please sign in to comment.