Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better feedback when commands fail #19

Open
ackoch opened this issue Apr 19, 2021 · 2 comments
Open

Better feedback when commands fail #19

ackoch opened this issue Apr 19, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@ackoch
Copy link

ackoch commented Apr 19, 2021

I would suggest, to make the cli commands a bit more consistent, verbose and failsafe.

Consistency: Some aio-cli commands take "json" files as input, some are interactive. It's better to have both options in all commands. If I had to choose, I'd prefer the non-interactive way - because that can be scripted (e.g. for ci/cd)

Failsafe: If Event-Metadata is mandatory, why not have it created with aio event provider create in one command? If there is a usecase for metadata-less providers, this could be done with a flag in the command (--nometadata) .. everything else will yield an error ("please provide metadata")..

Verboseness: The provider create command could create a hint ("Don't forget to register metadata"); the provider list could have a column for "metadata" or "metadata missing".

Verboseness: When registering an event (listener) and the provider does not have metadata or the event-code to be registered is not provided we should not return a 400-bad request but what specifically went wrong. If the underlying API does not provide that information, the client could provide some hints ("please check if the provider has metadata and it aligns with the event metadata you are registering for")

@meryllblanchet meryllblanchet added the enhancement New feature or request label Apr 19, 2021
@meryllblanchet
Copy link

Thanks for opening the issue and suggesting these enhancement @ackoch !

Let me loop in @theManikJindal as we are working on improving the Project Firefly <> I/O Events developer experience.

@purplecabbage
Copy link
Member

Adobe internal ticket:
https://jira.corp.adobe.com/browse/CI-6568

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants