Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make imports optional #118

Closed
hanoii opened this issue Feb 28, 2024 · 1 comment · Fixed by #119
Closed

Make imports optional #118

hanoii opened this issue Feb 28, 2024 · 1 comment · Fixed by #119

Comments

@hanoii
Copy link
Contributor

hanoii commented Feb 28, 2024

I would like imports to be defined but that they wouldn't err if the import file doesn't exist or it's empty.

@ocean
Copy link
Member

ocean commented Mar 1, 2024

Hi @hanoii thanks very much for this! Yes, I'm very happy to get contributions and pull requests from you, that would be great.

I'm nearing the end of a long a complex website release at the moment, so forgive me if I don't get a good look at this right away, but I do have some time planned soon to do some more things with ahoy.

Do you think you could write a test to demonstrate this feature working? You can write one in Go or bats, whichever works for you.

@ocean ocean closed this as completed in #119 Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants