Empty host crashes aiohttp

[Insoleet]

Hello,

The following line produce a crash :

        response = yield from aiohttp.get("http://:8001/crash")

The stack trace is the following :

  File "/usr/lib/python3.4/asyncio/tasks.py", line 238, in _step
    result = next(coro)
  File "/usr/lib/python3.4/site-packages/aiohttp/client.py", line 474, in get
    ret = yield from request(hdrs.METH_GET, url, **kwargs)
  File "/usr/lib/python3.4/site-packages/aiohttp/client.py", line 466, in request
    read_until_eof=read_until_eof)
  File "/usr/lib/python3.4/site-packages/aiohttp/client.py", line 129, in request
    loop=self._loop, response_class=self._response_class)
  File "/usr/lib/python3.4/site-packages/aiohttp/client_reqrep.py", line 77, in __init__
    self.update_host(url)
  File "/usr/lib/python3.4/site-packages/aiohttp/client_reqrep.py", line 118, in update_host
    host = host.encode('idna').decode('utf-8')
AttributeError: 'NoneType' object has no attribute 'encode'

[kxepal]

What did you expect? (:

[Insoleet]

Well shouldn't it raise a more comprehensive error ?
Like this one : https://github.com/KeepSafe/aiohttp/blob/master/aiohttp/client_reqrep.py#L111

[kxepal]

Should be easy to fix. Want to submit PR?

[Insoleet]

Ok I'll do. Shoud l write a unit test for this bug ?

[kxepal]

Yes. We don't want to have your changes accidentally get broken in future, do we?

[Insoleet]

Sure ;) I'll try to work on it tonight.

[kxepal]

Thanks! (:

[asvetlov]

Fixed by #511

[lock]

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.