Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AsyncAPI sse kafka filtering support #1137

Closed
akrambek opened this issue Jul 8, 2024 · 2 comments · Fixed by #1148
Closed

AsyncAPI sse kafka filtering support #1137

akrambek opened this issue Jul 8, 2024 · 2 comments · Fixed by #1148
Labels
bug Something isn't working

Comments

@akrambek
Copy link
Contributor

akrambek commented Jul 8, 2024

Add support for sse-kafka filtering.

For example.

      - when:
          - path: /payment-requests
        exit: kafka_cache_client1808eec1-480a-4f24-af7d-3a99101cc5b3
        with:
          event:
            id: '["${base64(key)}","${etag}"]'
          topic: payment-requests
          filters:
            - headers:
                zilla:identity: ${guarded['jwt3dc23de6-5185-46f8-86f7-717c3b023d8a'].identity}
@akrambek akrambek added the bug Something isn't working label Jul 8, 2024
@jfallows
Copy link
Contributor

jfallows commented Jul 8, 2024

@akrambek Perhaps we need to indicate this intent via the AsyncAPI spec, then honor it during config generation?

@jfallows jfallows changed the title AsyncApi sse kafka filtering support AsyncAPI sse kafka filtering support Jul 8, 2024
@jfallows
Copy link
Contributor

jfallows commented Jul 13, 2024

For example, in AsyncAPI operation bindings.

bindings:
  x-zilla-sse-kafka:
    filters:
      headers:
        zilla:identity: {identity}

generates

      - when:
          - path: /payment-requests
        exit: kafka_cache_client0
        with:
          event:
            id: '["${base64(key)}","${etag}"]'
          topic: payment-requests
          filters:
            - headers:
                zilla:identity: ${guarded[<guard-name>].identity}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants