Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Ask offers are not merged when having identical price #7

Open
alainsopp opened this issue Sep 20, 2023 · 0 comments
Open

New Ask offers are not merged when having identical price #7

alainsopp opened this issue Sep 20, 2023 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@alainsopp
Copy link
Owner

alainsopp commented Sep 20, 2023

Description
When executing a buy limit order with no available offers, a new
Ask offer is added on the market. However, if there is an ask
offer with the same amount, the total amount is not incremented
but a new offer with the same price is added.

To Reproduce
Steps to reproduce the behavior:

  1. Go to interface
  2. Fill amount and limit field with the value "1"
  3. Click on "Buy"
  4. See error

Expected behavior
The buy limit order offer is added to the market,
and the size for this offer it updated.
The new value is equal to the previous value
plus the new offer size value.

@alainsopp alainsopp added bug Something isn't working good first issue Good for newcomers labels Sep 20, 2023
@alainsopp alainsopp reopened this Sep 21, 2023
@alainsopp alainsopp changed the title Buy limit orders are executed over the limit New Ask offers are not merged when having identical price Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant