Code quality review (Codacy)

Author: aleab

Toastify/src/Core/Broadcaster/ToastifyBroadcaster.cs

@@ -122,7 +122,7 @@ public async Task StopAsync()
 
         private async Task SendCommand(string command, params string[] args)
         {
-            if (await this.EnsureConnection())
+            if (await this.EnsureConnection().ConfigureAwait(false))
             {
                 string argsString = string.Empty;
                 if (args != null && args.Length > 0)
@@ -131,14 +131,14 @@ private async Task SendCommand(string command, params string[] args)
                 byte[] bytes = Encoding.UTF8.GetBytes($"{command}{argsString}");
 
                 // Wait until the previous message has been sent: only one outstanding send operation is allowed!
-                await this.SendChannelAvailable();
+                await this.SendChannelAvailable().ConfigureAwait(false);
 
                 if (this.socket != null && this.socket.State == WebSocketState.Open)
                 {
                     try
                     {
                         this.isSending = true;
-                        await this.socket.SendAsync(new ArraySegment<byte>(bytes), WebSocketMessageType.Text, true, CancellationToken.None);
+                        await this.socket.SendAsync(new ArraySegment<byte>(bytes), WebSocketMessageType.Text, true, CancellationToken.None).ConfigureAwait(false);
                     }
                     finally
                     {
@@ -152,22 +152,22 @@ private async void ReceiveMessageLoop()
         {
             try
             {
-                if (!await this.EnsureConnection())
+                if (!await this.EnsureConnection().ConfigureAwait(false))
                 {
                     logger.Error("Couldn't establish a connection to the local WebSocket.");
                     return;
                 }
 
                 // Wait until the previous message has been received: only one outstanding receive operation is allowed!
-                await this.ReceiveChannelAvailable();
+                await this.ReceiveChannelAvailable().ConfigureAwait(false);
 
                 this.isReceiving = true;
                 var buffer = new byte[4 * 1024];
-                WebSocketReceiveResult receiveResult = await this.socket.ReceiveAsync(new ArraySegment<byte>(buffer), CancellationToken.None);
+                WebSocketReceiveResult receiveResult = await this.socket.ReceiveAsync(new ArraySegment<byte>(buffer), CancellationToken.None).ConfigureAwait(false);
                 this.isReceiving = false;
 
                 string message = string.Empty;
-                while (!receiveResult.CloseStatus.HasValue && await this.EnsureConnection())
+                while (!receiveResult.CloseStatus.HasValue && await this.EnsureConnection().ConfigureAwait(false))
                 {
                     if (receiveResult.MessageType == WebSocketMessageType.Text)
                     {
@@ -181,16 +181,16 @@ private async void ReceiveMessageLoop()
                     else
                         message = string.Empty;
 
-                    if (await this.EnsureConnection())
+                    if (await this.EnsureConnection().ConfigureAwait(false))
                     {
-                        await this.ReceiveChannelAvailable();
+                        await this.ReceiveChannelAvailable().ConfigureAwait(false);
                         this.isReceiving = true;
-                        receiveResult = await this.socket.ReceiveAsync(new ArraySegment<byte>(buffer), CancellationToken.None);
+                        receiveResult = await this.socket.ReceiveAsync(new ArraySegment<byte>(buffer), CancellationToken.None).ConfigureAwait(false);
                         this.isReceiving = false;
                     }
                 }
 
-                await this.socket.CloseAsync(WebSocketCloseStatus.NormalClosure, string.Empty, CancellationToken.None);
+                await this.socket.CloseAsync(WebSocketCloseStatus.NormalClosure, string.Empty, CancellationToken.None).ConfigureAwait(false);
             }
             catch (Exception e)
             {

Toastify/src/Core/Broadcaster/ToastifyWebSocketHostStartup.cs

@@ -133,17 +133,18 @@ private async Task HandleClients(string message, WebSocket clientWebSocket)
 
         public override void ConfigureServices(IServiceCollection services)
         {
+            // Nothing to configure
         }
 
         protected override async Task ConfigureWebSocketRequestPipeline(HttpContext context, Func<Task> next, WebSocket webSocket)
         {
             switch (context.Request.Path)
             {
-                case InternalPath:
+                case var s when s == InternalPath:
                     await this.WebSocketLoop(context, webSocket, this.HandleInternal).ConfigureAwait(false);
                     break;
 
-                case ClientsPath:
+                case var s when s == ClientsPath:
                     await this.WebSocketLoop(context, webSocket, this.HandleClients).ConfigureAwait(false);
                     break;
 
@@ -160,10 +161,10 @@ protected override bool ShouldAcceptConnection(HttpContext context, WebSocket we
 
             switch (context.Request.Path)
             {
-                case InternalPath:
+                case var s when s == InternalPath:
                     return this.toastifyBroadcasterSocket == null || this.toastifyBroadcasterSocket == webSocket;
 
-                case ClientsPath:
+                case var s when s == ClientsPath:
                     return true;
 
                 default:
@@ -177,11 +178,11 @@ protected override void OnWebSocketConnected(HttpContext context, WebSocket webS
 
             switch (context.Request.Path)
             {
-                case InternalPath:
+                case var s when s == InternalPath:
                     this.toastifyBroadcasterSocket = webSocket;
                     break;
 
-                case ClientsPath:
+                case var s when s == ClientsPath:
                     int i = Array.FindIndex(this.clients.ToArray(), w => w == webSocket);
                     if (i < 0)
                     {
@@ -210,12 +211,12 @@ protected override void OnWebSocketClosed(HttpContext context, WebSocket webSock
 
             switch (context.Request.Path)
             {
-                case InternalPath:
+                case var s when s == InternalPath:
                     if (this.toastifyBroadcasterSocket == webSocket)
                         this.toastifyBroadcasterSocket = null;
                     break;
 
-                case ClientsPath:
+                case var s when s == ClientsPath:
                     int i = Array.FindIndex(this.clients.ToArray(), w => w == webSocket);
                     if (i >= 0)
                         this.clients.RemoveAt(i);

ToastifyAPI.Tests/Logic/MouseHookHotkeyVisitorTest.cs

@@ -128,7 +128,7 @@ public IAction Action
             public MouseAction? MouseButton
             {
                 get { return MouseAction.XButton1; }
-                set { }
+                set { var _ = value; }
             }
 
             #endregion