Skip to content

Commit 983364c

Browse files
doc: onboarding process extras
Callout some practices explicitly, so that the process is followed in a similar manner PR-URL: nodejs#34455 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
1 parent adcf12c commit 983364c

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

onboarding.md

+3
Original file line numberDiff line numberDiff line change
@@ -210,6 +210,9 @@ needs to be pointed out separately during the onboarding.
210210
* Run CI on the PR. Use the `node-test-pull-request` CI task.
211211
* After two Collaborator approvals for the change and two Collaborator approvals
212212
for fast-tracking, land the PR.
213+
* Leave a comment in the PR: `Please 👍 this comment to approve fast-tracking`.
214+
* If there are not enough approvals within a reasonable time, consider the
215+
single approval of the onboarding TSC member sufficient, and land the PR.
213216
* Be sure to add the `PR-URL: <full-pr-url>` and appropriate `Reviewed-By:`
214217
metadata.
215218
* [`node-core-utils`][] automates the generation of metadata and the landing

0 commit comments

Comments
 (0)