Skip to content

Commit 1ca1515

Browse files
Sp1leustas
authored andcommitted
Fix missing symbols errors in libbrotlienc and dec (google#623)
When using autotools to build the binary and libraries, the resulting libraries don't link `brotlicommon` or `m`. This was detected when building cURL 7.57.0 which has now has brotli support. During configure it was failing ``` checking run-time libs availability... failed configure: error: one or more libs available at link-time are not available run-time. Libs used at link-time: -lbrotlidec -lz -L/usr/local/lib ``` inspection of config.log showed missing symbols from libbrotlicommon as the cause. This patch results in the encryption and decryption libs to be properly linked against libbrotlicommon and libm. See also https://bugs.freebsd.org/223966
1 parent 0ad94ee commit 1ca1515

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

Makefile.am

+2
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,10 @@ libbrotlicommon_la_SOURCES = $(BROTLI_COMMON_C) $(BROTLI_COMMON_H)
2323
libbrotlicommon_la_LDFLAGS = $(AM_LDFLAGS) $(LIBBROTLI_VERSION_INFO) $(LDFLAGS)
2424
libbrotlidec_la_SOURCES = $(BROTLI_DEC_C) $(BROTLI_DEC_H)
2525
libbrotlidec_la_LDFLAGS = $(AM_LDFLAGS) $(LIBBROTLI_VERSION_INFO) $(LDFLAGS)
26+
libbrotlidec_la_LIBADD = libbrotlicommon.la -lm
2627
libbrotlienc_la_SOURCES = $(BROTLI_ENC_C) $(BROTLI_ENC_H)
2728
libbrotlienc_la_LDFLAGS = $(AM_LDFLAGS) $(LIBBROTLI_VERSION_INFO) $(LDFLAGS)
29+
libbrotlienc_la_LIBADD = libbrotlicommon.la -lm
2830

2931
pkgconfigdir = $(libdir)/pkgconfig
3032
pkgconfig_DATA = \

0 commit comments

Comments
 (0)