Merge pull request #3105 from alphagov/stop-al-description-test

Revert "Add annual leave entitlement AB test"

Author: sihugh

app/assets/stylesheets/smart_answers.scss

@@ -375,19 +375,4 @@ $is-ie: false !default;
     vertical-align: top;
   }
 
-  .ab-context {
-    padding: 0;
-    margin:  0;
-
-    h2 {
-      border: none;
-      @include bold-19;
-      margin: 0 0 1em;
-      position: relative;
-
-      @include ie-lte(8) {
-        line-height: 1.2em;
-      }
-    }
-  }
 }

app/controllers/concerns/benchmark_holiday_entitlement_ab_testable.rb

@@ -2,7 +2,6 @@ class SmartAnswersController < ApplicationController
   include Slimmer::GovukComponents
   include Slimmer::Headers
   include EducationNavigationABTestable
-  include BenchmarkHolidayEntitlementABTestable
 
   before_action :find_smart_answer, except: %w(index)
   before_action :redirect_response_to_canonical_url, only: %w{show}
@@ -16,8 +15,6 @@ class SmartAnswersController < ApplicationController
     :should_present_new_navigation_view?,
     :page_is_under_ab_test?,
     :present_taxonomy_sidebar?,
-    :is_holiday_entitlement_tested_path?,
-    :should_show_holiday_entitlement_variant?
   )
 
   rescue_from SmartAnswer::FlowRegistry::NotFound, with: :error_404
@@ -38,10 +35,6 @@ def show
           set_education_navigation_response_header(content_item)
         end
 
-        if is_holiday_entitlement_tested_path?
-          set_benchmark_holiday_entitlement_response_header
-        end
-
         render page_type
       }
       if Rails.application.config.expose_govspeak

app/controllers/smart_answers_controller.rb

@@ -7,10 +7,6 @@
   <% if page_is_under_ab_test?(@content_item) %>
     <%= education_navigation_variant.analytics_meta_tag.html_safe %>
   <% end %>
-
-  <% if is_holiday_entitlement_tested_path? %>
-    <%= benchmark_holiday_entitlement_variant.analytics_meta_tag.html_safe %>
-  <% end %>
 <% end %>
 
 <% if should_present_new_navigation_view?(@content_item) %>

app/views/layouts/smart_answers.html.erb

@@ -16,12 +16,7 @@
   <article role="article" class="group" data-debug-template-path="<%= start_node.relative_erb_template_path %>">
     <div class="inner">
       <div class="intro">
-
-      <% if should_show_holiday_entitlement_variant? %>
-        <%= start_node.ab_body %>
-      <% else %>
         <%= start_node.body %>
-      <% end %>
 
         <p class="get-started">
           <a rel="nofollow" href="<%= start_button_href %>" class="big button"><%= start_button %></a>

app/views/smart_answers/landing.html.erb

@@ -9,22 +9,6 @@
 <% question = @presenter.current_node %>
 
 <div class="step current">
-
-  <% if should_show_holiday_entitlement_variant? %>
-    <div class="ab-context">
-      <h2 id="leave-year-dates">
-        Leave year dates
-      </h2>
-      <p>
-       The leave year will usually be in an employee’s contract. If it isn’t, their leave year will start:
-      </p>
-      <ul>
-        <li>on their first day (if the job began after 1 October 1998)</li>
-        <li>on 1 October (if the job began on or before 1 October 1998)</li>
-      </ul>
-    </div>
-  <% end %>
-
   <%= form_tag calculate_current_question_path(@presenter), :method => :get %>
     <div class="current-question" id="current-question">
 

app/views/smart_answers/question.html.erb

@@ -20,11 +20,3 @@
   - on 1 October (if the job began on or before 1 October 1998)
 
 <% end %>
-
-<% content_for :ab_body do %>
-  Use this tool to calculate holiday entitlement for:
-
-  - a full leave year
-  - part of a leave year, if the job started or finished part way through the year
-
-<% end %>

lib/smart_answer_flows/calculate-your-holiday-entitlement/calculate_your_holiday_entitlement.govspeak.erb

@@ -1,6 +1,6 @@
 ---
 lib/smart_answer/calculators/holiday_entitlement.rb: dab915508991c038dcc0fd51935bcf82
-lib/smart_answer_flows/calculate-your-holiday-entitlement/calculate_your_holiday_entitlement.govspeak.erb: 2ef053da554acbe99f7fb8df8126f9a1
+lib/smart_answer_flows/calculate-your-holiday-entitlement/calculate_your_holiday_entitlement.govspeak.erb: 448c48df1c04abbf03ded760e29a227f
 lib/smart_answer_flows/calculate-your-holiday-entitlement/outcomes/_your_employer_with_rounding.govspeak.erb: 968b6d15a99334328227528f3feea6ba
 lib/smart_answer_flows/calculate-your-holiday-entitlement/outcomes/annualised_hours_done.govspeak.erb: 5be498f482bc4686f612cdca0dbbc2ab
 lib/smart_answer_flows/calculate-your-holiday-entitlement/outcomes/casual_or_irregular_hours_done.govspeak.erb: f2b0964438fdb8b9ef4aaa4972bd7041

test/data/calculate-your-holiday-entitlement-files.yml

@@ -15,7 +15,3 @@
   These questions three
   Ere the other side he see.
 <% end %>
-
-<% content_for :ab_body do %>
-  There are some who call me Tim!
-<% end %>

test/fixtures/smart_answer_flows/bridge-of-death/bridge_of_death.govspeak.erb

@@ -274,97 +274,6 @@ def teardown
     end
   end
 
-  context "Annual leave descrption placement A/B testing" do
-    context "pages in test" do
-      setup do
-        @controller.stubs(:is_holiday_entitlement_tested_path?).returns(true)
-
-        content_item = {
-          "base_path" => '/bridge-of-death'
-        }
-
-        Services.content_store.stubs(:content_item)
-          .with("/bridge-of-death")
-          .returns(content_item)
-      end
-
-      context "landing page" do
-        should "show the original text for the 'A' version" do
-          with_variant BenchmarkALDescription1: "A" do
-            get :show, params: { id: 'bridge-of-death' }
-
-            assert_match(/He who would cross the Bridge of Death/, response.body)
-            assert_no_match(/Tim/, response.body)
-          end
-        end
-
-        should "show the alternate text for the 'B' version" do
-          with_variant BenchmarkALDescription1: "B" do
-            get :show, params: { id: 'bridge-of-death' }
-
-            assert_match(/There are some who call me Tim!/, response.body)
-            assert_no_match(/these questions threee/, response.body)
-          end
-        end
-      end
-
-      context "question page" do
-        should "show the original text for the 'A' version" do
-          with_variant BenchmarkALDescription1: "A" do
-            get :show, params: { id: 'bridge-of-death', started: 'y', responses: ['what-is-your-quest'] }
-
-            assert_match(/To seek the Holy Grail/, response.body)
-            assert_no_match(/The leave year will/, response.body)
-          end
-        end
-
-        should "show the additional text for the 'B' version" do
-          with_variant BenchmarkALDescription1: "B" do
-            get :show, params: { id: 'bridge-of-death', started: 'y', responses: ['what-is-your-quest'] }
-
-            assert_match(/The leave year will/, response.body)
-            assert_match(/To seek the Holy Grail/, response.body)
-          end
-        end
-      end
-    end
-
-    context "pages not in test" do
-      setup do
-        @controller.stubs(:is_holiday_entitlement_tested_path?).returns(false)
-
-        content_item = {
-          "base_path" => '/bridge-of-death'
-        }
-
-        Services.content_store.stubs(:content_item)
-          .with("/bridge-of-death")
-          .returns(content_item)
-      end
-
-      context "landing page" do
-        should "show the original text" do
-          setup_ab_variant "BenchmarkCmButton1", "B"
-
-          get :show, params: { id: 'bridge-of-death' }
-          assert_match(/He who would cross the Bridge of Death/, response.body)
-          assert_no_match(/Tim/, response.body)
-        end
-      end
-
-      context "question page" do
-        should "show the original text" do
-          setup_ab_variant "BenchmarkCmButton1", "B"
-
-          get :show, params: { id: 'bridge-of-death', started: 'y', responses: ['what-is-your-quest'] }
-
-          assert_match(/To seek the Holy Grail/, response.body)
-          assert_no_match(/The leave year will/, response.body)
-        end
-      end
-    end
-  end
-
   context "GET /<slug>/visualise" do
     should "display the visualisation" do
       stub_smart_answer_in_content_store("smart-answers-controller-sample")