Use ERB tags to interpolate values in template

These were not dealt with automatically by the conversion script.

I've also elected to inline the phrases from the i18n YAML file into the flow
`precalculate` blocks. Note that I've had to mark on of them as HTML-safe to
avoid an apostrophe being HTML-escaped. This isn't ideal, but I'd hope that
these strings would move into the ERB template or a helper method where this
would be easier to deal with.

Author: floehopper

lib/smart_answer_flows/calculate-your-child-maintenance.rb

@@ -29,7 +29,11 @@ def define
         end
 
         precalculate :paying_or_receiving_hint do
-          PhraseList.new(:"#{paying_or_receiving}_hint")
+          if paying_or_receiving == "pay"
+            "Enter the total number of children - including children that you have family based arrangements for. They will be included in the calculation and you'll need to supply information about them when arranging Child Maintenance.".html_safe
+          else
+            "Enter children from 1 partner only and make a separate calculation for each partner."
+          end
         end
 
         calculate :number_of_children do |response|
@@ -47,7 +51,11 @@ def define
         option "no"
 
         precalculate :benefits_title do
-          PhraseList.new(:"#{paying_or_receiving}_benefits")
+          if paying_or_receiving == "pay"
+            "Do you get any of these benefits?"
+          else
+            "Does the parent paying child maintenance get any of these benefits?"
+          end
         end
 
         calculate :calculator do
@@ -72,7 +80,11 @@ def define
       money_question :gross_income_of_payee? do
 
         precalculate :income_title do
-          PhraseList.new(:"#{paying_or_receiving}_income")
+          if paying_or_receiving == "pay"
+            "What is your weekly gross income?"
+          else
+            "What is the weekly gross income of the parent paying child maintenance?"
+          end
         end
 
         next_node_calculation :rate_type do |response|
@@ -101,7 +113,11 @@ def define
       value_question :how_many_other_children_in_payees_household?, parse: Integer do
 
         precalculate :number_of_children_title do
-          PhraseList.new(:"#{paying_or_receiving}_number_of_children")
+          if paying_or_receiving == "pay"
+            "How many other children live in your household?"
+          else
+            "How many other children live in the household of the parent paying child maintenance?"
+          end
         end
 
         calculate :calculator do |response|
@@ -120,7 +136,11 @@ def define
         option 4
 
         precalculate :how_many_nights_title do
-          PhraseList.new(:"#{paying_or_receiving}_how_many_nights")
+          if paying_or_receiving == "pay"
+            "On average, how many nights a year do the children stay over with you?"
+          else
+            "On average, how many nights a year do the children stay over with the parent paying child maintenance?"
+          end
         end
 
         calculate :child_maintenance_payment do |response|

lib/smart_answer_flows/calculate-your-child-maintenance/questions/gets_benefits.govspeak.erb

@@ -1,5 +1,5 @@
 <% content_for :title do %>
-  %{benefits_title}
+  <%= benefits_title %>
 <% end %>
 
 <% options(

lib/smart_answer_flows/calculate-your-child-maintenance/questions/gross_income_of_payee.govspeak.erb

@@ -1,5 +1,5 @@
 <% content_for :title do %>
-  %{income_title}
+  <%= income_title %>
 <% end %>
 
 <% content_for :hint do %>

lib/smart_answer_flows/calculate-your-child-maintenance/questions/how_many_children_paid_for.govspeak.erb

@@ -1,5 +1,5 @@
 <% content_for :title do %>
-  How many children are you %{paying_or_receiving_text} child maintenance for?
+  How many children are you <%= paying_or_receiving_text %> child maintenance for?
 <% end %>
 
 <% options(
@@ -9,5 +9,5 @@
 ) %>
 
 <% content_for :hint do %>
-  %{paying_or_receiving_hint}
+  <%= paying_or_receiving_hint %>
 <% end %>

lib/smart_answer_flows/calculate-your-child-maintenance/questions/how_many_nights_children_stay_with_payee.govspeak.erb

@@ -1,5 +1,5 @@
 <% content_for :title do %>
-  %{how_many_nights_title}
+  <%= how_many_nights_title %>
 <% end %>
 
 <% options(

lib/smart_answer_flows/calculate-your-child-maintenance/questions/how_many_other_children_in_payees_household.govspeak.erb

@@ -1,5 +1,5 @@
 <% content_for :title do %>
-  %{number_of_children_title}
+  <%= number_of_children_title %>
 <% end %>
 
 <% content_for :hint do %>

test/integration/smart_answer_flows/calculate_child_maintenance_test.rb

@@ -31,7 +31,7 @@ class CalculateChildMaintentanceTest < ActiveSupport::TestCase
 
       should "ask do you get any of these benefits" do
         assert_current_node :gets_benefits?
-        assert_phrase_list :paying_or_receiving_hint, [:pay_hint]
+        assert_state_variable :paying_or_receiving_hint, "Enter the total number of children - including children that you have family based arrangements for. They will be included in the calculation and you'll need to supply information about them when arranging Child Maintenance."
       end
 
       context "answer yes" do