Rubocop fixes

Author: floehopper

app/presenters/question_presenter.rb

@@ -6,14 +6,14 @@ class QuestionPresenter < NodePresenter
     :translate_option
   ] => :@renderer
 
-  delegate :use_erb_template? => :@node
+  delegate use_erb_template?: :@node
 
   def initialize(i18n_prefix, node, state = nil, options = {})
     super(i18n_prefix, node, state)
     @renderer = options[:renderer]
     helpers = options[:helpers] || []
     if use_erb_template?
-      @renderer ||=  SmartAnswer::ErbRenderer.new(
+      @renderer ||= SmartAnswer::ErbRenderer.new(
         template_directory: @node.template_directory.join('questions'),
         template_name: @node.filesystem_friendly_name,
         locals: @state.to_hash,

lib/smart_answer/flow.rb

@@ -134,14 +134,15 @@ def normalize_responses(responses)
     class InvalidStatus < StandardError; end
 
     private
-      def add_question(klass, name, options = {}, &block)
-        options.reverse_merge!(use_erb_template: @use_erb_templates_for_questions)
-        add_node klass.new(self, name, options, &block)
-      end
 
-      def add_node(node)
-        raise "Node #{node.name} already defined" if node_exists?(node)
-        @nodes << node
-      end
+    def add_question(klass, name, options = {}, &block)
+      options.reverse_merge!(use_erb_template: @use_erb_templates_for_questions)
+      add_node klass.new(self, name, options, &block)
+    end
+
+    def add_node(node)
+      raise "Node #{node.name} already defined" if node_exists?(node)
+      @nodes << node
+    end
   end
 end

lib/smart_answer/question/base.rb

@@ -12,7 +12,7 @@ def initialize(flow, name, options = {}, &block)
         @permitted_next_nodes = []
         @predicate_stack = []
         @predicates = {}
-        @use_erb_template = options[:use_erb_template]
+        @uses_erb_template = options[:use_erb_template]
         super
       end
 
@@ -128,7 +128,7 @@ def question?
       end
 
       def use_erb_template?
-        @use_erb_template
+        @uses_erb_template
       end
 
     private

script/convert-question-i18-yaml-to-erb-templates.rb

@@ -26,16 +26,17 @@ def normalize_blank_lines(string)
     rendered_options = options.inject([]) do |array, (key, value)|
       array << "#{key.to_s.inspect}: #{value.inspect}".indent(2)
       array
-    end.join(",\n")
-    options_erb = "<% options(\n#{rendered_options}\n) %>"
+    end
+    options_erb = "<% options(\n#{rendered_options.join(",\n")}\n) %>"
   end
   error_attributes = attributes.except(*%w(title options hint label suffix_label body post_body))
-  errors_erb = error_attributes.inject([]) do |array, (key, value)|
+  errors = error_attributes.inject([]) do |array, (key, value)|
     array << "<% content_for #{key.to_sym.inspect} do %>"
     array << value.indent(2)
     array << "<% end %>"
     array
-  end.join("\n")
+  end
+  errors_erb = errors.join("\n")
   erb = File.read(Rails.root.join('script', 'templates', 'question.erb'))
   template = Erubis::Eruby.new(erb)
   template_name = question_key.sub(/\?$/, '') + '.govspeak.erb'

test/unit/question_presenter_with_erb_renderer_test.rb

@@ -73,8 +73,8 @@ class QuestionPresenterWithErbRendererTest < ActiveSupport::TestCase
       @renderer.stubs(:option_text).with(:option_two).returns('option-two-text')
       presenter = QuestionPresenter.new('i18n-prefix', question, state = nil, renderer: @renderer)
 
-      assert_equal ['option_one', 'option_two'], presenter.options.map(&:value)
-      assert_equal ['option-one-text', 'option-two-text'], presenter.options.map(&:label)
+      assert_equal %w(option_one option_two), presenter.options.map(&:value)
+      assert_equal %w(option-one-text option-two-text), presenter.options.map(&:label)
     end
 
     test '#error returns nil if there is no error' do