Add #three_day_residency_requirement_applies?

Use it instead of the `:three_day_residency_requirement_applies`
precalculate block.

Part of refactoring marriage-abroad. See doc/refactoring.md for more.

Author: chrisroos

lib/smart_answer/calculators/marriage_abroad_calculator.rb

@@ -240,6 +240,10 @@ def outcome_path_when_resident_in_ceremony_country
       outcome_path_when_resident_in('ceremony_country')
     end
 
+    def three_day_residency_requirement_applies?
+      MarriageAbroadDataQuery::THREE_DAY_RESIDENCY_REQUIREMENT_COUNTRIES.include?(ceremony_country)
+    end
+
   private
 
     def outcome_path_when_resident_in(uk_or_ceremony_country)

lib/smart_answer_flows/marriage-abroad.rb

@@ -254,9 +254,6 @@ def define
       outcome :outcome_consular_cni_os_residing_in_third_country
 
       outcome :outcome_os_consular_cni do
-        precalculate :three_day_residency_requirement_applies do
-          Calculators::MarriageAbroadDataQuery::THREE_DAY_RESIDENCY_REQUIREMENT_COUNTRIES
-        end
         precalculate :three_day_residency_handled_by_exception do
           Calculators::MarriageAbroadDataQuery::THREE_DAY_RESIDENCY_HANDLED_BY_EXCEPTION
         end

lib/smart_answer_flows/marriage-abroad/outcomes/outcome_os_consular_cni.govspeak.erb

@@ -136,7 +136,7 @@
 
     <% end %>
 
-    <% if three_day_residency_handled_by_exception.exclude?(calculator.ceremony_country) && three_day_residency_requirement_applies.include?(calculator.ceremony_country) %>
+    <% if three_day_residency_handled_by_exception.exclude?(calculator.ceremony_country) && calculator.three_day_residency_requirement_applies? %>
       <%= render partial: "three_day_residency_requirement.govspeak.erb",
                  locals: {
                    country_name_lowercase_prefix: calculator.country_name_lowercase_prefix

test/unit/calculators/marriage_abroad_calculator_test.rb

@@ -760,6 +760,22 @@ class MarriageAbroadCalculatorTest < ActiveSupport::TestCase
           assert_equal expected_path, calculator.outcome_path_when_resident_in_ceremony_country
         end
       end
+
+      context '#three_day_residency_requirement_applies?' do
+        should 'return true if ceremony country requires 3 day residency' do
+          calculator = MarriageAbroadCalculator.new
+          calculator.ceremony_country = 'albania'
+
+          assert calculator.three_day_residency_requirement_applies?
+        end
+
+        should 'return false if ceremony country does not require 3 days residency' do
+          calculator = MarriageAbroadCalculator.new
+          calculator.ceremony_country = 'country-not-requiring-three-day-residency'
+
+          refute calculator.three_day_residency_requirement_applies?
+        end
+      end
     end
   end
 end