Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Use AutoMapper for object-object mapping #45

Open
jenia90 opened this issue Oct 18, 2019 · 6 comments
Open

[Suggestion] Use AutoMapper for object-object mapping #45

jenia90 opened this issue Oct 18, 2019 · 6 comments
Labels
enhancement New feature or request

Comments

@jenia90
Copy link
Contributor

jenia90 commented Oct 18, 2019

Currently we use manual mapping of DTOs to their respective DB entities which clutters the code.

Proposed solution
It would be nice to use AutoMapper library for automatic mapping of objects.

Alternative solution
An alternative solution, in case we don't want to add more packages, would be to implement Map() extension methods for every objects.

@amoraitis amoraitis added enhancement New feature or request blocked labels Oct 19, 2019
@amoraitis
Copy link
Owner

I like this, but first, wait for @ncindric to close his PR #46. I don't want him to fight with conflicts.

Blocked by #42.

@jenia90
Copy link
Contributor Author

jenia90 commented Oct 19, 2019

@amoraitis sure, in the mean time I'll look into what is needed for implementing it in your project. If you don't want to take it yourself, I'd like to be assigned to it :)

@amoraitis
Copy link
Owner

amoraitis commented Oct 19, 2019

@jenia90 I would like to work on this, too. But, it's your issue, it's up to you.

What I would do: I would open an AutoMapper branch here and we could contribute to that branch together.

What do you think?

@jenia90
Copy link
Contributor Author

jenia90 commented Oct 19, 2019

@amoraitis Sounds like a good idea!

@amoraitis amoraitis removed the blocked label Oct 23, 2019
@amoraitis
Copy link
Owner

@jenia90
Copy link
Contributor Author

jenia90 commented Oct 23, 2019

@amoraitis Awesome! But how do we split the work so we don't interfere each other?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants