-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Video blocks can cause validation errors in AMP Stories #2109
Milestone
Comments
7 tasks
To verify:
|
Note that the “autoplay” and “plays inline” options actually shouldn't be displayed at all: The video should automatically be autoplaying when you preview on the frontend. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When adding a video block to an AMP Story page and hitting Save an AMP validation error appears:
This is due to the video not having:
autoplay
poster
When supplying these the validation error goes away:
When a video is shown in an AMP Stories context, the
autoplay
toggle should be enabled by default and either disabled or hidden entirely.Also, the
playsinline
toggle needs to be removed in the stories context since it is not allowed:Additionally, since we don't currently automatically extract a poster image from a video (see #903) there should be a warning displayed with either the poster field to indicate it is required.
The text was updated successfully, but these errors were encountered: