Skip to content

Commit 304b3bd

Browse files
LuBaolujoergroedel
authored andcommitted
iommu/vt-d: Remove caching mode check before device TLB flush
The Caching Mode (CM) of the Intel IOMMU indicates if the hardware implementation caches not-present or erroneous translation-structure entries except for the first-stage translation. The caching mode is irrelevant to the device TLB, therefore there is no need to check it before a device TLB invalidation operation. Remove two caching mode checks before device TLB invalidation in the driver. The removal of these checks doesn't change the driver's behavior in critical map/unmap paths. Hence, there is no functionality or performance impact, especially since commit <29b32839725f> ("iommu/vt-d: Do not use flush-queue when caching-mode is on") has already disabled flush-queue for caching mode. Therefore, caching mode will never call intel_flush_iotlb_all(). Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com> Reviewed-by: Kevin Tian <kevin.tian@intel.com> Reviewed-by: Yi Liu <yi.l.liu@intel.com> Link: https://lore.kernel.org/r/20240415013835.9527-1-baolu.lu@linux.intel.com Signed-off-by: Joerg Roedel <jroedel@suse.de>
1 parent 621b7e5 commit 304b3bd

File tree

1 file changed

+2
-7
lines changed

1 file changed

+2
-7
lines changed

drivers/iommu/intel/iommu.c

+2-7
Original file line numberDiff line numberDiff line change
@@ -1502,11 +1502,7 @@ static void iommu_flush_iotlb_psi(struct intel_iommu *iommu,
15021502
else
15031503
__iommu_flush_iotlb_psi(iommu, did, pfn, pages, ih);
15041504

1505-
/*
1506-
* In caching mode, changes of pages from non-present to present require
1507-
* flush. However, device IOTLB doesn't need to be flushed in this case.
1508-
*/
1509-
if (!cap_caching_mode(iommu->cap) || !map)
1505+
if (!map)
15101506
iommu_flush_dev_iotlb(domain, addr, mask);
15111507
}
15121508

@@ -1580,8 +1576,7 @@ static void intel_flush_iotlb_all(struct iommu_domain *domain)
15801576
iommu->flush.flush_iotlb(iommu, did, 0, 0,
15811577
DMA_TLB_DSI_FLUSH);
15821578

1583-
if (!cap_caching_mode(iommu->cap))
1584-
iommu_flush_dev_iotlb(dmar_domain, 0, MAX_AGAW_PFN_WIDTH);
1579+
iommu_flush_dev_iotlb(dmar_domain, 0, MAX_AGAW_PFN_WIDTH);
15851580
}
15861581

15871582
if (dmar_domain->nested_parent)

0 commit comments

Comments
 (0)