Skip to content

Commit 7728eee

Browse files
committed
url: use ada::url_aggregator for parsing urls
PR-URL: nodejs#47339 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
1 parent f9259fd commit 7728eee

File tree

9 files changed

+478
-257
lines changed

9 files changed

+478
-257
lines changed

lib/internal/url.js

+198-60
Large diffs are not rendered by default.

lib/url.js

+2-4
Original file line numberDiff line numberDiff line change
@@ -59,9 +59,7 @@ const {
5959
urlToHttpOptions,
6060
} = require('internal/url');
6161

62-
const {
63-
formatUrl,
64-
} = internalBinding('url');
62+
const bindingUrl = internalBinding('url');
6563

6664
const { getOptionValue } = require('internal/options');
6765

@@ -627,7 +625,7 @@ function urlFormat(urlObject, options) {
627625
}
628626
}
629627

630-
return formatUrl(urlObject.href, fragment, unicode, search, auth);
628+
return bindingUrl.format(urlObject.href, fragment, unicode, search, auth);
631629
}
632630

633631
return Url.prototype.format.call(urlObject);

src/node_snapshotable.cc

+1
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
#include "node_metadata.h"
1919
#include "node_process.h"
2020
#include "node_snapshot_builder.h"
21+
#include "node_url.h"
2122
#include "node_util.h"
2223
#include "node_v8.h"
2324
#include "node_v8_platform-inl.h"

src/node_snapshotable.h

+1
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ struct PropInfo {
2727
V(v8_binding_data, v8_utils::BindingData) \
2828
V(blob_binding_data, BlobBindingData) \
2929
V(process_binding_data, process::BindingData) \
30+
V(url_binding_data, url::BindingData) \
3031
V(util_weak_reference, util::WeakReference)
3132

3233
enum class EmbedderObjectType : uint8_t {

0 commit comments

Comments
 (0)