Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doesn't bump if #none is contained in a previous commit message and the default version bump is not none #330

Open
nyoungstudios opened this issue Nov 24, 2024 · 0 comments

Comments

@nyoungstudios
Copy link
Contributor

Usage:

- name: Bump version and push tag
  id: create-tag
  uses: anothrNick/github-tag-action@1.71.0
  env:
    GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
    WITH_V: true

If I make a commit message commit one #none, then I expect no version bump to be made. This is what happens. However, if I make the next commit without a version bump message, commit two, I still expect this action to made the default version bump. Instead, this action doesn't make a version bump in this case because #none is still present in the previous commit message.

Is my explanation what should be expected? Or was this made on purpose?

In other words, I feel like the log variable should only be the last commit message:

log=${history_type[${branch_history}]}

Here is my configuration:

*** CONFIGURATION ***
	DEFAULT_BUMP: minor
	DEFAULT_BRANCH: 
	WITH_V: true
	RELEASE_BRANCHES: master,main
	CUSTOM_TAG: 
	SOURCE: .
	DRY_RUN: false
	GIT_API_TAGGING: true
	INITIAL_VERSION: 0.0.0
	TAG_CONTEXT: repo
	PRERELEASE: false
	PRERELEASE_SUFFIX: beta
	VERBOSE: false
	MAJOR_STRING_TOKEN: #major
	MINOR_STRING_TOKEN: #minor
	PATCH_STRING_TOKEN: #patch
	NONE_STRING_TOKEN: #none
	BRANCH_HISTORY: compare
	FORCE_WITHOUT_CHANGES: false
	FORCE_WITHOUT_CHANGES_PRE: false
	TAG_MESSAGE: 
pre_release = false
History:
---
commit two

commit one #none

---
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant