Skip to content

Commit 1ce2478

Browse files
authored
Change node to 16+ (#1829)
* Change node to 16+ this involves the `lockfileVersion` switch from 1 to 2 No-Issue * workflows: switch to node 16 cd .github/workflows/ sed -i '/node/s/14/16/' * * Dockerfile, README - switch to node 16+ * node16: update lockfiles nvm use 16 npm install --save @types/node@16 cd test npm install
1 parent e9c480c commit 1ce2478

11 files changed

+19198
-5498
lines changed

.github/workflows/cypress.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -111,10 +111,10 @@ jobs:
111111
with:
112112
path: 'ansible-hub-ui'
113113

114-
- name: "Install node 14"
114+
- name: "Install node 16"
115115
uses: actions/setup-node@v2
116116
with:
117-
node-version: '14'
117+
node-version: '16'
118118

119119
- name: "Cache ~/.npm & ~/.cache/Cypress"
120120
uses: actions/cache@v2

.github/workflows/deploy-cloud.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,10 @@ jobs:
4040
echo "TRAVIS_BUILD_WEB_URL=${TRAVIS_BUILD_WEB_URL}" >> $GITHUB_ENV
4141
echo -e "TRAVIS_COMMIT_MESSAGE<<EOF\n${TRAVIS_COMMIT_MESSAGE}\nEOF" >> $GITHUB_ENV
4242
43-
- name: "Install node 14"
43+
- name: "Install node 16"
4444
uses: actions/setup-node@v2
4545
with:
46-
node-version: '14'
46+
node-version: '16'
4747

4848
- name: "Cache ~/.npm"
4949
uses: actions/cache@v2

.github/workflows/dev-release.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,10 @@ jobs:
2323
- name: "Checkout ansible-hub-ui (${{ github.ref }})"
2424
uses: actions/checkout@v2
2525

26-
- name: "Install node 14"
26+
- name: "Install node 16"
2727
uses: actions/setup-node@v2
2828
with:
29-
node-version: '14'
29+
node-version: '16'
3030

3131
- name: "Update the dev tag"
3232
run: |

.github/workflows/pr-checks.yml

+4-4
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,10 @@ jobs:
3333
- name: "Checkout ansible-hub-ui (${{ github.ref }})"
3434
uses: actions/checkout@v2
3535

36-
- name: "Install node 14"
36+
- name: "Install node 16"
3737
uses: actions/setup-node@v2
3838
with:
39-
node-version: '14'
39+
node-version: '16'
4040
cache: 'npm'
4141

4242
- name: "Checks"
@@ -93,10 +93,10 @@ jobs:
9393
with:
9494
path: 'pr'
9595

96-
- name: "Install node 14"
96+
- name: "Install node 16"
9797
uses: actions/setup-node@v2
9898
with:
99-
node-version: '14'
99+
node-version: '16'
100100
cache: 'npm'
101101
cache-dependency-path: |
102102
base/package-lock.json

.github/workflows/stable-release.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,10 @@ jobs:
2828
RELEASE_TAG=`sed 's/^refs\/tags\///' <<< $GITHUB_REF`
2929
echo "RELEASE_TAG=${RELEASE_TAG}" >> $GITHUB_ENV
3030
31-
- name: "Install node 14"
31+
- name: "Install node 16"
3232
uses: actions/setup-node@v2
3333
with:
34-
node-version: '14'
34+
node-version: '16'
3535

3636
- name: "Cache ~/.npm"
3737
uses: actions/cache@v2

.github/workflows/update-manifest.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,10 @@ jobs:
2828
- name: "Checkout ansible-hub-ui (${{ github.ref }})"
2929
uses: actions/checkout@v2
3030

31-
- name: "Install node 14"
31+
- name: "Install node 16"
3232
uses: actions/setup-node@v2
3333
with:
34-
node-version: '14'
34+
node-version: '16'
3535

3636
- name: "Run update_manifest.sh"
3737
run: .travis/update_manifest.sh

Dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# WARNING
22
# This Dockerfile is intended for development purposes only. Do not use it for production deployments
33

4-
FROM node:14-alpine3.10
4+
FROM node:16-alpine
55
WORKDIR /hub/
66

77
RUN mkdir -p /hub/app/ && \

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ This app can be developed in standalone mode or insights mode. Insights mode com
1515
### Develop in Standalone Mode
1616

1717
1. Clone the [galaxy_ng](https://github.com/ansible/galaxy_ng) repo and follow the instructions for starting up the API.
18-
2. Install node. Node v14+ is known to work. Older versions may work as well.
18+
2. Install node. Node v16+ is known to work. Older versions may work as well.
1919
3. `npm install`
2020
4. `npm run start-standalone`
2121

0 commit comments

Comments
 (0)