Skip to content

Commit 9b02b08

Browse files
committed
tests - constistent kebab-toggle click
1 parent 291ed9d commit 9b02b08

File tree

5 files changed

+10
-10
lines changed

5 files changed

+10
-10
lines changed

src/constants.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ export class Constants {
2626
];
2727

2828
static TASK_NAMES = {
29-
'galaxy_ng.app.tasks.curate_all_synclist_repository': msg`Curate all synclist repository`,
29+
'galaxy_ng.app.tasks.curate_all_synclist_repository': msg`Curate all synclist repositories`,
3030
'galaxy_ng.app.tasks.curate_synclist_repository': msg`Curate synclist repository`,
3131
'galaxy_ng.app.tasks.import_and_auto_approve': msg`Import and auto approve`,
3232
'galaxy_ng.app.tasks.import_and_move_to_staging': msg`Import and move to staging`,

test/cypress/e2e/collections/collection.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ describe('collection tests', () => {
2222

2323
cy.visit(`${uiPrefix}repo/published/test_namespace/test_collection`);
2424

25-
cy.get('[data-cy=kebab-toggle]').click();
25+
cy.get('[data-cy="kebab-toggle"] [aria-label="Actions"]').click();
2626
cy.get('[data-cy=delete-collection]').click();
2727
cy.get('input[id=delete_confirm]').click();
2828
cy.get('button').contains('Delete').click();
@@ -41,7 +41,7 @@ describe('collection tests', () => {
4141
cy.get(
4242
`a[href*="${uiPrefix}repo/published/my_namespace/my_collection"]`,
4343
).click();
44-
cy.get('[data-cy=kebab-toggle]').click();
44+
cy.get('[data-cy="kebab-toggle"] [aria-label="Actions"]').click();
4545
cy.get('[data-cy=delete-collection-version]').click();
4646
cy.get('input[id=delete_confirm]').click();
4747
cy.get('button').contains('Delete').click();
@@ -62,7 +62,7 @@ describe('collection tests', () => {
6262
cy.galaxykit('task wait all');
6363
cy.visit(`${uiPrefix}repo/published/${namespace}/${collection}`);
6464

65-
cy.get('[data-cy="kebab-toggle"]').click();
65+
cy.get('[data-cy="kebab-toggle"] [aria-label="Actions"]').click();
6666
cy.get(
6767
'[data-cy="copy-collection-version-to-repository-dropdown"]',
6868
).click();
@@ -156,7 +156,7 @@ describe('collection tests', () => {
156156
`${uiPrefix}repo/repo2/test_namespace/test_repo_collection_version2/?version=1.0.0`,
157157
);
158158

159-
cy.get('[data-cy="kebab-toggle"] [aria-label="Actions"]:first').click();
159+
cy.get('[data-cy="kebab-toggle"] [aria-label="Actions"]').click();
160160
cy.contains('Remove version 1.0.0 from repository').click();
161161
cy.get('input[id=delete_confirm]').click();
162162
cy.get('button').contains('Delete').click();

test/cypress/e2e/collections/collection_upload.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ describe('Collection Upload Tests', () => {
6464
cy.login();
6565
cy.visit(`${uiPrefix}repo/published/testspace/testcollection`);
6666
cy.contains('testcollection');
67-
cy.get('[data-cy="kebab-toggle"] button[aria-label="Actions"]').click();
67+
cy.get('[data-cy="kebab-toggle"] [aria-label="Actions"]').click();
6868
cy.contains('Upload new version').click();
6969
cy.contains('New version of testspace.testcollection');
7070
});

test/cypress/e2e/insights_collections/collection.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ describe('collection tests', () => {
1717

1818
cy.visit(`${uiPrefix}repo/published/test_namespace/test_collection`);
1919

20-
cy.get('[data-cy=kebab-toggle]').click();
20+
cy.get('[data-cy="kebab-toggle"] [aria-label="Actions"]').click();
2121
cy.get('[data-cy=delete-collection]').click();
2222
cy.get('input[id=delete_confirm]').click();
2323
cy.get('button').contains('Delete').click();
@@ -36,7 +36,7 @@ describe('collection tests', () => {
3636
cy.get(
3737
`a[href*="${uiPrefix}repo/published/my_namespace/my_collection"]`,
3838
).click();
39-
cy.get('[data-cy=kebab-toggle]').click();
39+
cy.get('[data-cy="kebab-toggle"] [aria-label="Actions"]').click();
4040
cy.get('[data-cy=delete-collection-version]').click();
4141
cy.get('input[id=delete_confirm]').click();
4242
cy.get('button').contains('Delete').click();

test/cypress/e2e/misc/rbac.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ describe('RBAC test for user without permissions', () => {
6565
cy.visit(`${uiPrefix}repo/published/testspace/testcollection`);
6666

6767
// cannot Delete collection
68-
cy.get('[data-cy=kebab-toggle]').should('not.exist');
68+
cy.get('[data-cy="kebab-toggle"]').should('not.exist');
6969
});
7070

7171
it("shouldn't let view, add, change and delete users when user doesn't have permission", () => {
@@ -287,7 +287,7 @@ describe('RBAC test for user with permissions', () => {
287287
cy.visit(`${uiPrefix}repo/published/testspace2/testcollection2`);
288288

289289
// can Delete collection
290-
cy.get('[data-cy=kebab-toggle]').should('exist').click();
290+
cy.get('[data-cy="kebab-toggle"] [aria-label="Actions"]').click();
291291
cy.contains('Delete collection from system');
292292
});
293293

0 commit comments

Comments
 (0)