Skip to content
This repository was archived by the owner on Feb 25, 2019. It is now read-only.

sentinel support and ioredis #125

Closed
christiansmith opened this issue Jul 21, 2015 · 6 comments · Fixed by anvilresearch/modinha-redis#8
Closed

sentinel support and ioredis #125

christiansmith opened this issue Jul 21, 2015 · 6 comments · Fixed by anvilresearch/modinha-redis#8

Comments

@christiansmith
Copy link
Member

Even as we're looking to roll our own embedded distributed backend and move away from Redis, users are asking for high-availability Redis support.

Recently someone reached out by email to ask about porting to ioredis, in order to support sentinel. Looks like it could be fairly straightforward to switch redis clients. Anyone interested to work on this?

@adalinesimonian
Copy link
Member

I think prior to this we should run through connect and rip out any redis-specific code and work it into modinha-redis.

@christiansmith
Copy link
Member Author

@vsimonian yes, we'd have to. Although in doing that, we'd make modinha-redis specific to this application. I think that's probably an acceptable tradeoff since it's very unlikely that that particular lib is in use anywhere else.

@adalinesimonian
Copy link
Member

ioredis is named such because it requires io.js instead of node.js, correct? If so, how's the integration of node.js and io.js coming along?

@adalinesimonian
Copy link
Member

Re: my last comment, it looks like the name doesn't refer to io.js in particular, and ioredis supports node.js as well. Sounds like a go to me.

@christiansmith
Copy link
Member Author

I think this might be a good weekend hack.

@adalinesimonian
Copy link
Member

👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants