Merge pull request #8 from anvilresearch/vsimonian-ioredis

Use ioredis

Author: christiansmith

lib/RedisDocument.js

@@ -295,8 +295,8 @@ RedisDocument.delete = function (id, callback) {
     })
 
     // execute the set of ops
-    multi.exec(function (err) {
-      if (err) { callback(err) }
+    multi.exec(function (err, result) {
+      if (err) { return callback(err) }
       callback(null, true)
     })
   })

package.json

@@ -37,8 +37,8 @@
   },
   "dependencies": {
     "async": "^1.3.0",
-    "modinha": "0.0.30",
-    "redis": "^0.12.1"
+    "ioredis": "^1.7.5",
+    "modinha": "0.0.30"
   },
   "bugs": {
     "url": "https://github.com/anvilresearch/modinha-redis/issues"

test/RedisDocumentIndexingSpec.coffee

@@ -5,6 +5,7 @@ Faker     = require 'faker'
 chai      = require 'chai'
 sinon     = require 'sinon'
 sinonChai = require 'sinon-chai'
+mockMulti = require './lib/multi'
 expect    = chai.expect
 
 
@@ -25,10 +26,10 @@ RedisDocument = require path.join(cwd, 'lib/RedisDocument')
 
 
 # Redis lib for spying and stubbing
-redis   = require 'redis'
-client  = redis.createClient()
-multi   = redis.Multi.prototype
-rclient = redis.RedisClient.prototype
+Redis   = require 'ioredis'
+client  = new Redis({ port: 12345 })
+rclient = Redis.prototype
+multi   = mockMulti(rclient)
 
 
 
@@ -96,7 +97,7 @@ describe 'Indexing', ->
       field: ['$', ['nested.$', 'flag']]
       value: '_id'
 
-    Document.__redis = redis
+    Document.__redis = Redis
     Document.__client = client
 
     # Mock data

test/RedisDocumentRelationshipSpec.coffee

@@ -5,6 +5,7 @@ path      = require 'path'
 chai      = require 'chai'
 sinon     = require 'sinon'
 sinonChai = require 'sinon-chai'
+mockMulti = require './lib/multi'
 expect    = chai.expect
 
 
@@ -24,11 +25,11 @@ RedisDocument = require path.join(cwd, 'lib/RedisDocument')
 
 
 
-## Redis lib for spying and stubbing
-redis   = require 'redis'
-client  = redis.createClient()
-multi   = redis.Multi.prototype
-rclient = redis.RedisClient.prototype
+# Redis lib for spying and stubbing
+Redis   = require 'ioredis'
+client  = new Redis({ port: 12345 })
+rclient = Redis.prototype
+multi   = mockMulti(rclient)
 
 
 

test/RedisDocumentSpec.coffee

@@ -5,6 +5,7 @@ faker     = require 'faker'
 chai      = require 'chai'
 sinon     = require 'sinon'
 sinonChai = require 'sinon-chai'
+mockMulti = require './lib/multi'
 expect    = chai.expect
 
 
@@ -25,13 +26,10 @@ RedisDocument = require path.join(cwd, 'lib/RedisDocument')
 
 
 # Redis lib for spying and stubbing
-redis   = require 'redis'
-multi   = redis.Multi.prototype
-rclient = redis.RedisClient.prototype
-rclient.ready_check = ->
-rclient.install_stream_listeners = ->
-rclient.connection_gone = ->
-client  = new redis.RedisClient({}, {})
+Redis   = require 'ioredis'
+client  = new Redis({ port: 12345 })
+rclient = Redis.prototype
+multi   = mockMulti(rclient)
 
 
 
@@ -58,7 +56,7 @@ describe 'RedisDocument', ->
     Document.extend RedisDocument
 
 
-    Document.__redis = redis
+    Document.__redis = Redis
     Document.__client = client
 
     # Mock data

test/lib/multi.coffee

@@ -0,0 +1,29 @@
+Redis = require 'ioredis'
+client = Redis.prototype
+
+multi = {}
+multiOld = client.multi
+multiMethods = []
+
+for key of client
+  if typeof client[key] == 'function'
+    multiMethods.push key
+
+multiMethods.forEach (prop) ->
+  multi[prop] = ->
+    multi
+  return
+
+multi.exec = ->
+  throw new Error('exec called without being stubbed')
+  return
+
+module.exports = (client) ->
+  client.multi = ->
+    multi
+
+  client.multi.restore = ->
+    client.multi = multiOld
+    return
+
+  multi