Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Replace snappy with other crc32c packages for tfrecordio #34226

Open
2 of 17 tasks
liferoad opened this issue Mar 9, 2025 · 3 comments
Open
2 of 17 tasks

Comments

@liferoad
Copy link
Contributor

liferoad commented Mar 9, 2025

What would you like to happen?

The latest snappy (>=0.7) does not use crc32c directly now. We should explore other crc32c packages to replace snappy. Some candidates: https://pypi.org/project/crc32c/ and https://pypi.org/project/google-crc32c/.

See #33407 with more details

Issue Priority

Priority: 2 (default / most feature requests should be filed as P2)

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam YAML
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Infrastructure
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Samza Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner
@Brijeshthummar02
Copy link

@liferoad can you explain more about issue, also provide me path to file. i will have a look.

@liferoad
Copy link
Contributor Author

liferoad commented Mar 10, 2025

We use this to compute a masked crc32c checksum for a value:

if getattr(snappy, '_crc32c', None):

I do not think we need snappy any more since we could directly use some crc32c packages.

cc @tvalentyn

@tvalentyn
Copy link
Contributor

Yes, I also saw that fastavro implementation is moving away from snappy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants