Right Click Context Menu text missing

[KnightBlood]

Expected behavior

No response

Actual behavior

No response

Steps to reproduce the problem

JMeter Version

5.5

Java Version

No response

OS Version

No response

[FSchumacher]

While I can reproduce the context menu and it does not have text in my locale either, I am not sure, this is not intended nor where this context menu is coming from.

[Ninja-Cyborg]

On my local machine it's working fine. The paste option is active as you can paste copied data. But, to perform copy, delete or cut, one needs to select the text first. Otherwise, there is no data to perform those action.

[FSchumacher]

What I meant by it does not have text is shown in your picture as well as in the original one. There is no text right to the icons (cut, copy, paste, delete). But I still don't know if that is not intentional.

[Ninja-Cyborg]

Oh! I misunderstood that. Thanks, for clarification.
@FSchumacher can I tag you in issues that might be good to close or some other action myself?
I am new to open-source contributions, still learning to be more useful.

[KnightBlood]

What I meant by_it does not have text_is shown in your picture as well as in the original one. There is no text right to the icons (cut, copy, paste, delete). But I still don't know if that is not intentional.

In earlier versions(4.x or 3.x), it have texts

[FSchumacher]

What I meant by_it does not have text_is shown in your picture as well as in the original one. There is no text right to the icons (cut, copy, paste, delete). But I still don't know if that is not intentional.

In earlier versions(4.x or 3.x), it have texts

Do you have an idea, when it stopped working? Otherwise, I would have to try quite a lot of versions myself :)

[FSchumacher]

Oh! I misunderstood that. Thanks, for clarification. @FSchumacher can I tag you in issues that might be good to close or some other action myself? I am new to open-source contributions, still learning to be more useful.

No need to tag me, I will read the changes on the issues anyway. Feel free to help other users by replying to issues or choosing appropriate tags on the issues.
If you think an issue can be closed, it will be best to check, that a solution has been pointed out on the issue and either the OP has confirmed its usefulness or not responded in a timely manner (give them quite some time).

[FSchumacher]

I checked the earlier versions 3.x and 4.x and neither of those seem to have had the context menus. It appeared after release 5.3 with full text displayed, but the text disappeared before the release of 5.4 with commit id 222546c. That commit changed the dependency of darklaf from 2.4.8 to 2.4.10.

[FSchumacher]

Could you try to change the Look&Feel to some other Darklaf based one (say yes to restart JMeter) and report back, whether the text re-appears after the change?

I found the change in darklaf, that resulted in the missing text, but I don't know, what we have to do differently to initialize it correctly. Perhaps @weisJ can shed some light on this?

[weisJ]

It has been some time since I fixed this issue in darklaf (see weisJ/darklaf@ff34a3e), but if I recall correctly it is caused by the stricter module encapsulation in newer Java versions. In older versions of darklaf the resource bundles containing these texts were loaded directly from the jdk, which is now considered as illegal access. It should be fixed with an upgrade of darklaf. Though there are some fixed I want to release first. I’ll update in the next few days :)

[FSchumacher]

I tried the open PR #5715 but it didn't bring back the text. Did you mean a newer version, you are currently working on?

[weisJ]

I have found out what is causing the problem. See my comment at #5715