Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to extend KnownHostServerKeyVerifier handling of revoked keys #652

Closed
joeljohansson99 opened this issue Jan 10, 2025 · 2 comments · Fixed by #653
Closed

Add option to extend KnownHostServerKeyVerifier handling of revoked keys #652

joeljohansson99 opened this issue Jan 10, 2025 · 2 comments · Fixed by #653
Labels
feature request A request for a new feature
Milestone

Comments

@joeljohansson99
Copy link
Contributor

Description

Currently, KnownHostServerKeyVerifier does not have handle for revoked keys. It simply returns false. It would be good to abstract it to a separate function that you can override if you want to handle it in a specific way. Now you need to override acceptKnownHostEntries in order to add special handling.

Motivation

It would be a lot easier to add functionality when a revoked key matches. E.g. giving information to the user, etc.

Alternatives considered

A seperate function to log etc when a revoked key matches.
Currently overriding acceptKnownHostEntries.

Additional context

No response

@tomaswolf tomaswolf added the feature request A request for a new feature label Jan 11, 2025
@tomaswolf
Copy link
Member

Do you want to provide a PR?

@joeljohansson99
Copy link
Contributor Author

Sure, will do. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request A request for a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants