Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatic persisted queries does not work with mutations #1100

Closed
DaniilSokolyuk opened this issue Mar 27, 2020 · 2 comments
Closed

Automatic persisted queries does not work with mutations #1100

DaniilSokolyuk opened this issue Mar 27, 2020 · 2 comments
Labels
bug Generally incorrect behavior
Milestone
0.25.0

Comments

@DaniilSokolyuk
Copy link

Automatic persisted queries does not work with mutations, only for query.

There are no restrictions in the documention , only

For full-length queries and for all mutations, Apollo Client will continue to use POST requests.
@designatednerd
Copy link
Contributor

It looks like when it was initially implemented it was only implemented for queries and didn't send the APQ info for mutations. Looks like there's not a technical limit to this, just that we're not handling that at the moment.

My bandwidth is somewhat limited at the moment, but if you're interested in doing a PR to address this I'd be happy to take a look!

@designatednerd designatednerd added bug Generally incorrect behavior help wanted Issues the Apollo team would love help from the community about labels Mar 27, 2020
@IvanStebletsov IvanStebletsov mentioned this issue Mar 31, 2020
Merged
@designatednerd designatednerd removed the help wanted Issues the Apollo team would love help from the community about label Mar 31, 2020
@designatednerd designatednerd added this to the Next Release milestone Mar 31, 2020
@designatednerd
Copy link
Contributor

Shipped with 0.25.0. Up for SPM and Carthage, publishing to CocoaPods trunk now.

@DaniilSokolyuk DaniilSokolyuk mentioned this issue Aug 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Generally incorrect behavior
Projects
None yet
Milestone
0.25.0
Development

No branches or pull requests
2 participants
@designatednerd @DaniilSokolyuk