Km/follow file wb mode (#209)

* use File.open as wb mode when tests save base64 decoded data

* fix rubocop

Author: KazuCocoa

lib/appium_lib_core/common/base/driver.rb

@@ -435,9 +435,12 @@ def push_file(path, filedata)
         #
         # @example
         #
-        #   @driver.pull_file '/local/data/some/path'     #=> Get the file at that path
-        #   @driver.pull_file 'Shenanigans.app/some/file' #=> Get 'some/file' from the install location of Shenanigans.app
-        #   @driver.pull_file '@com.appium.example/Documents/file.txt' #=> Get 'file.txt' in @com.appium.example/Documents
+        #   decoded_file = @driver.pull_file '/local/data/some/path'     #=> Get the file at that path
+        #   decoded_file = @driver.pull_file 'Shenanigans.app/some/file'
+        #                  #=> Get 'some/file' from the install location of Shenanigans.app
+        #   decoded_file = @driver.pull_file '@com.appium.example/Documents/file.txt'
+        #                  #=> Get 'file.txt' in @com.appium.example/Documents
+        #   File.open('proper_filename', 'wb') { |f| f<< decoded_file }
         #
         def pull_file(path)
           @bridge.pull_file(path)
@@ -469,8 +472,9 @@ def pull_file(path)
         #
         # @example
         #
-        #   @driver.pull_folder '/data/local/tmp' #=> Get the folder at that path
-        #   @driver.pull_file '@com.appium.example/Documents' #=> Get 'Documents' in @com.appium.example
+        #   decoded_file = @driver.pull_folder '/data/local/tmp' #=> Get the folder at that path
+        #   decoded_file = @driver.pull_file '@com.appium.example/Documents' #=> Get 'Documents' in @com.appium.example
+        #   File.open('proper_filename', 'wb') { |f| f<< decoded_file }
         #
         def pull_folder(path)
           @bridge.pull_folder(path)

test/functional/android/android/device_test.rb

@@ -412,12 +412,12 @@ def test_file_management
         @driver.push_file sdcard_file_path, file
 
         read_file = @driver.pull_file sdcard_file_path
-        File.write 'test.png', read_file
+        File.open('test.png', 'wb') { |f| f << read_file }
 
         assert_equal File.size(test_file), File.size('test.png')
 
         folder = @driver.pull_folder sdcard_path
-        File.write 'pic_folder.zip', folder
+        File.open('pic_folder.zip', 'wb') { |f| f << folder }
 
         assert File.exist?('pic_folder.zip')
 

test/functional/android/android/image_comparison_test.rb

@@ -39,7 +39,7 @@ def test_image_comparison_match_result
 
         match_result_visual = @driver.match_images_features first_image: image1, second_image: image2, visualize: true
         assert_equal %w(points1 rect1 points2 rect2 totalCount count visualization), match_result_visual.keys
-        File.write 'match_result_visual.png', Base64.decode64(match_result_visual['visualization'])
+        File.open('match_result_visual.png', 'wb') { |f| f << Base64.decode64(match_result_visual['visualization']) }
         assert File.size? 'match_result_visual.png'
 
         File.delete 'match_result_visual.png'
@@ -56,7 +56,7 @@ def test_image_comparison_find_result
 
         find_result_visual = @driver.find_image_occurrence full_image: image1, partial_image: image2, visualize: true
         assert_equal %w(rect visualization), find_result_visual.keys
-        File.write 'find_result_visual.png', Base64.decode64(find_result_visual['visualization'])
+        File.open('find_result_visual.png', 'wb') { |f| f << Base64.decode64(find_result_visual['visualization']) }
         assert File.size? 'find_result_visual.png'
 
         File.delete 'find_result_visual.png'
@@ -73,7 +73,7 @@ def test_image_comparison_get_images_result
 
         get_images_result_visual = @driver.get_images_similarity first_image: image1, second_image: image2, visualize: true
         assert_equal %w(score visualization), get_images_result_visual.keys
-        File.write 'get_images_result_visual.png', Base64.decode64(get_images_result_visual['visualization'])
+        File.open('get_images_result_visual.png', 'wb') { |f| f << Base64.decode64(get_images_result_visual['visualization']) }
         assert File.size? 'get_images_result_visual.png'
 
         File.delete 'get_images_result_visual.png'

test/functional/ios/ios/image_comparison_test.rb

@@ -24,11 +24,11 @@ module Ios
     class ImageComparisionTest < AppiumLibCoreTest::Function::TestCase
       def setup
         @@core = ::Appium::Core.for(Caps.ios)
-        @driver = @@core.start_driver
+        @@driver = @@core.start_driver
       end
 
       def teardown
-        save_reports(@driver)
+        save_reports(@@driver)
       end
 
       def test_image_comparison_match_result
@@ -42,7 +42,7 @@ def test_image_comparison_match_result
 
         match_result_visual = @@driver.match_images_features first_image: image1, second_image: image2, visualize: true
         assert_equal %w(points1 rect1 points2 rect2 totalCount count visualization), match_result_visual.keys
-        File.write 'match_result_visual.png', Base64.decode64(match_result_visual['visualization'])
+        File.open('match_result_visual.png', 'wb') { |f| f << Base64.decode64(match_result_visual['visualization']) }
         assert File.size? 'match_result_visual.png'
 
         File.delete 'match_result_visual.png'
@@ -59,7 +59,7 @@ def test_image_comparison_find_result
 
         find_result_visual = @@driver.find_image_occurrence full_image: image1, partial_image: image2, visualize: true
         assert_equal %w(rect visualization), find_result_visual.keys
-        File.write 'find_result_visual.png', Base64.decode64(find_result_visual['visualization'])
+        File.open('find_result_visual.png', 'wb') { |f| f << Base64.decode64(find_result_visual['visualization']) }
         assert File.size? 'find_result_visual.png'
 
         File.delete 'find_result_visual.png'
@@ -76,7 +76,7 @@ def test_image_comparison_get_images_result
 
         get_images_result_visual = @@driver.get_images_similarity first_image: image1, second_image: image2, visualize: true
         assert_equal %w(score visualization), get_images_result_visual.keys
-        File.write 'get_images_result_visual.png', Base64.decode64(get_images_result_visual['visualization'])
+        File.open('get_images_result_visual.png', 'wb') { |f| f << Base64.decode64(get_images_result_visual['visualization']) }
         assert File.size? 'get_images_result_visual.png'
 
         File.delete 'get_images_result_visual.png'