add tests for symbolize_keys (#146)

* add tests for symbolize_keys

* add argumenterror

* Update appium_lib_core.rb

Author: KazuCocoa

lib/appium_lib_core.rb

@@ -16,13 +16,19 @@ module Appium
   # https://github.com/rails/docrails/blob/a3b1105ada3da64acfa3843b164b14b734456a50/activesupport/lib/active_support/core_ext/hash/keys.rb#L84
   # @param [Hash] hash Hash value to make symbolise
   def self.symbolize_keys(hash)
-    raise 'symbolize_keys requires a hash' unless hash.is_a? Hash
-    result = {}
-    hash.each do |key, value|
-      key = key.to_sym rescue key # rubocop:disable Style/RescueModifier
-      result[key] = value.is_a?(Hash) ? symbolize_keys(value) : value
+    raise ArgumentError, 'symbolize_keys requires a hash' unless hash.is_a? Hash
+
+    hash.each_with_object({}) do |pair, acc|
+      key = begin
+        pair[0].to_sym
+      rescue StandardError => e
+        ::Appium::Logger.warn(e.message)
+        pair[0]
+      end
+
+      value = pair[1]
+      acc[key] = value.is_a?(Hash) ? symbolize_keys(value) : value
     end
-    result
   end
 
   module Core

test/appium_lib_core_test.rb

@@ -0,0 +1,27 @@
+require 'test_helper'
+
+class AppiumLibCoreTest
+  class RootTest < Minitest::Test
+    def test_version
+      assert !::Appium::Core::VERSION.nil?
+    end
+
+    def test_symbolize_keys
+      result = ::Appium.symbolize_keys({ 'a' => 1, b: 2 })
+      assert_equal({ a: 1, b: 2 }, result)
+    end
+
+    def test_symbolize_keys_nested
+      result = ::Appium.symbolize_keys({ 'a' => 1, b: { 'c' => 2, d: 3 } })
+      assert_equal({ a: 1, b: { c: 2, d: 3 } }, result)
+    end
+
+    def test_symbolize_keys_raise_argument_error
+      e = assert_raises ArgumentError do
+        ::Appium.symbolize_keys('no hash value')
+      end
+
+      assert_equal 'symbolize_keys requires a hash', e.message
+    end
+  end
+end