ci: runs tests on windows host as GitHub Actions (#272)

* ci: runs tests on windows host as GitHub Actions

* tweak

* move env

* tweak ffi

* only bundle install once

* only bundle install once

* do install dependencies in the same section

* remove bundle exec on win

* fix warning

* tweak rubocop

* specify version

* specify version..

* do not run 2.7 on windows for now

Author: KazuCocoa

.github/workflows/unittest.yml

@@ -15,6 +15,9 @@ jobs:
 
     runs-on: ubuntu-latest
 
+    env:
+      UNIT_TEST: true
+
     steps:
     - uses: actions/checkout@v2
     - name: Set up Ruby
@@ -26,6 +29,40 @@ jobs:
     - name: Run tests
       run: |
         bundle exec rake rubocop
-        UNIT_TEST=true bundle exec parallel_test test/unit/ -n 4
-        UNIT_TEST=true AUTOMATION_NAME_DROID=espresso bundle exec parallel_test test/unit/android -n 4
-        UNIT_TEST=true AUTOMATION_NAME_DROID=appium AUTOMATION_NAME_IOS=appium bundle exec parallel_test test/unit -n 4
+        bundle exec parallel_test test/unit/ -n 4
+        AUTOMATION_NAME_DROID=espresso bundle exec parallel_test test/unit/android -n 4
+        AUTOMATION_NAME_DROID=appium AUTOMATION_NAME_IOS=appium bundle exec parallel_test test/unit -n 4
+
+  test-win:
+    strategy:
+      fail-fast: false
+      matrix:
+        # Does not add 2.7 on Windows so far since a command fails only on Windows
+        ruby: [2.2, 2.3, 2.4, 2.5, 2.6]
+
+    runs-on: windows-latest
+
+    env:
+      UNIT_TEST: true
+
+    steps:
+      - uses: actions/checkout@v2
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby }}
+      - name: Install dependencies
+        run: |
+          gem install ffi
+          bundle install
+          gem uninstall --force eventmachine && gem install eventmachine --platform ruby
+      - name: Run tests
+        run: |
+          parallel_test test/unit/ -n 4
+
+          setx AUTOMATION_NAME_DROID espresso
+          parallel_test test/unit/android -n 4
+
+          setx AUTOMATION_NAME_DROID appium
+          setx AUTOMATION_NAME_IOS appium
+          parallel_test test/unit -n 4

.rubocop.yml

@@ -11,9 +11,9 @@ Metrics/ClassLength:
 Metrics/AbcSize:
   Enabled: false
 Metrics/CyclomaticComplexity:
-  Max: 13
+  Max: 14
 Metrics/PerceivedComplexity:
-  Max: 13
+  Max: 14
 Metrics/ParameterLists:
   Enabled: false
 Lint/NestedMethodDefinition:

azure-pipelines.yml

@@ -4,26 +4,6 @@
 # https://docs.microsoft.com/azure/devops/pipelines/languages/ruby
 jobs:
   - template: ./ci-jobs/functional_test.yml
-  - job: Run_unit_tests_on_Windows_environment
-    pool:
-      vmImage: 'vs2017-win2016'
-    variables:
-      UNIT_TEST: true
-    steps:
-      - task: UseRubyVersion@0
-        inputs:
-          versionSpec: '2.5'
-      - script: gem install bundler ffi:1.10.0
-        displayName: 'Gem install bundler and ffi for Windows environment'
-      - script: bundle install --retry=3 --jobs=4
-        displayName: 'Call bundle install'
-      - script: gem uninstall --force eventmachine && gem install eventmachine --platform ruby
-        displayName: 'bundle re-install eventmachine for Windows because of Windows environment issue'
-      - script: parallel_test test/unit/ -n 4
-        displayName: 'Run parallel_test test/unit/ -n 4'
-      - template: ./ci-jobs/functional/publish_test_result.yml
-        parameters:
-          xcodeVersion: 'Run_unit_tests_on_Windows_environment'
 
 # Runs tests nightly to make sure they works against appium@beta
 schedules:

lib/appium_lib_core/android/device.rb

@@ -412,6 +412,9 @@ def end_coverage(path, intent)
             end
 
             ::Appium::Core::Device.add_endpoint_method(:execute_cdp) do
+              # SeleniumWebdriver could already define this method
+              return if method_defined? :execute_cdp
+
               def execute_cdp(cmd, **params)
                 execute :chrome_send_command, {}, { cmd: cmd, params: params }
               end