chore: add deprecation marks in core (#430)

* add deprecation mark in core.quit_driver

* chore: tweak comments

* deprecate platform_version, not necessary for the  core

* remove  override since 4.2 has the same

* add missing endpoints

* add missing endpoints more

* add missing endpoints more

* tweak spaces

* use  driver.quit in tests

Author: KazuCocoa

lib/appium_lib_core/common/base/bridge.rb

@@ -211,11 +211,6 @@ def session_capabilities
           ::Appium::Core::Base::Capabilities.json_create execute(:get_capabilities)
         end
 
-        # Override for safe. Newer ruby selenium webdriver already has the same code
-        def page_source
-          execute :get_page_source
-        end
-
         # For Appium
         # override
         def element_displayed?(element)
@@ -229,7 +224,8 @@ def element_displayed?(element)
         # override
         def element_attribute(element, name)
           # For W3C in Selenium Client
-          # execute_atom :getAttribute, element, name
+          # execute_atom :getAttribute, element, name.
+          # 'dom_attribute' in the WebDriver Selenium.
           execute :get_element_attribute, id: element.id, name: name
         end
 

lib/appium_lib_core/common/command.rb

@@ -70,11 +70,15 @@ module Commands
         find_elements: [:post, 'session/:session_id/elements'],
         find_child_element: [:post, 'session/:session_id/element/:id/element'],
         find_child_elements: [:post, 'session/:session_id/element/:id/elements'],
+        find_shadow_child_element: [:post, 'session/:session_id/shadow/:id/element'],
+        find_shadow_child_elements: [:post, 'session/:session_id/shadow/:id/elements'],
         get_active_element: [:get, 'session/:session_id/element/active'],
         is_element_selected: [:get, 'session/:session_id/element/:id/selected'],
         get_element_attribute: [:get, 'session/:session_id/element/:id/attribute/:name'],
         get_element_property: [:get, 'session/:session_id/element/:id/property/:name'],
         get_element_css_value: [:get, 'session/:session_id/element/:id/css/:property_name'],
+        get_element_aria_role: [:get, 'session/:session_id/element/:id/computedrole'],
+        get_element_aria_label: [:get, 'session/:session_id/element/:id/computedlabel'],
         get_element_text: [:get, 'session/:session_id/element/:id/text'],
         get_element_tag_name: [:get, 'session/:session_id/element/:id/name'],
         get_element_rect: [:get, 'session/:session_id/element/:id/rect'],

lib/appium_lib_core/driver.rb

@@ -328,7 +328,7 @@ def initialize
       public
 
       # @private
-      # Set up for a neww session
+      # Set up for a new session
       def setup_for_new_session(opts = {})
         @custom_url = opts.delete :url # to set the custom url as :url
 
@@ -443,7 +443,7 @@ def start_driver(server_url: nil,
         @driver
       end
 
-      # @privvate
+      # @private
       # Attach to an existing session
       def attach_to(session_id, url: nil, automation_name: nil, platform_name: nil,
                     http_client_ops: { http_client: nil, open_timeout: 999_999, read_timeout: 999_999 })
@@ -509,14 +509,15 @@ def set_implicit_wait_by_default(wait)
         {}
       end
 
-      # Quits the driver
+      # [Deprecated] Quits the driver. This method is the same as @driver.quit
       # @return [void]
       #
       # @example
       #
       #   @core.quit_driver
       #
       def quit_driver
+        ::Appium::Logger.warn('[DEPRECATION] quit_driver will be removed. Please use @driver.quit instead.')
         @driver.quit
       rescue # rubocop:disable Style/RescueStandardError
         nil
@@ -562,6 +563,11 @@ def appium_server_version
       #     @core.platform_version #=> [10,1,1]
       #
       def platform_version
+        ::Appium::Logger.warn(
+          '[DEPRECATION] platform_version method will be. ' \
+          'Please check the platformVersion via @driver.capabilities["platformVersion"] instead.'
+        )
+
         p_version = @driver.capabilities['platformVersion'] || @driver.session_capabilities['platformVersion']
         p_version.split('.').map(&:to_i)
       end

test/functional/android/android/device_data_test.rb

@@ -26,7 +26,7 @@ def setup
 
       def teardown
         save_reports(@driver)
-        @@core.quit_driver
+        @driver&.quit
       end
 
       def test_push_and_pull_file

test/functional/android/android/device_test.rb

@@ -26,7 +26,7 @@ def setup
 
       def teardown
         save_reports(@driver)
-        @@core.quit_driver
+        @driver&.quit
       end
 
       def test_window_size

test/functional/android/android/mjpeg_server_test.rb

@@ -26,7 +26,7 @@ def setup
 
       def teardown
         save_reports(@driver)
-        @@core.quit_driver
+        @driver&.quit
       end
 
       def test_start_recording_screen

test/functional/android/android/mobile_commands_test.rb

@@ -24,7 +24,7 @@ def setup
 
       def teardown
         save_reports(@driver)
-        @core.quit_driver
+        @driver&.quit
       end
 
       # @since Appium 1.12.0

test/functional/android/android/search_context_test.rb

@@ -26,7 +26,7 @@ def setup
 
       def teardown
         save_reports(@driver)
-        @@core.quit_driver
+        @driver&.quit
       end
 
       def test_uiautomator

test/functional/android/driver_test.rb

@@ -25,7 +25,7 @@ def setup
 
     def teardown
       save_reports(@driver)
-      @@core.quit_driver
+      @driver&.quit
     end
 
     def test_appium_server_version

test/functional/android/patch_test.rb

@@ -25,7 +25,7 @@ def setup
 
     def teardown
       save_reports(@driver)
-      @@core.quit_driver
+      @driver&.quit
     end
 
     def test_method_missing_attributes

test/functional/android/webdriver/create_session_test.rb

@@ -27,7 +27,7 @@ def test_w3c_default
         driver = core.start_driver
         assert !driver.capabilities.nil?
 
-        core.quit_driver
+        driver&.quit
       end
     end
   end

test/functional/android/webdriver/device_test.rb

@@ -27,7 +27,7 @@ def setup
 
       def teardown
         save_reports(@driver)
-        @@core.quit_driver
+        @driver&.quit
       end
 
       def test_capabilities

test/functional/android/webdriver/w3c_actions_test.rb

@@ -27,7 +27,7 @@ def setup
 
       def teardown
         save_reports(@driver)
-        @@core.quit_driver
+        @driver&.quit
       end
 
       def test_tap_scroll