use default_move_duration (#115)

* use default_move_duration

* remove hotfix of page source in w3c

* update changelog

Author: KazuCocoa

CHANGELOG.md

@@ -6,6 +6,7 @@ All notable changes to this project will be documented in this file.
 - Update documentation about `start_recording_screen`
 - Port `send_keys/type` for active element
 - Support `find_element/s :image, partial_image`
+- Requires `selenium-webdriver 3.14+` because of W3C actions
 
 ### Bug fixes
 

appium_lib_core.gemspec

@@ -22,7 +22,7 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.add_runtime_dependency 'selenium-webdriver', '~> 3.5', '< 3.14'
+  spec.add_runtime_dependency 'selenium-webdriver', '~> 3.14'
   spec.add_runtime_dependency 'faye-websocket', '~> 0.10.0'
 
   spec.add_development_dependency 'bundler', '~> 1.14'

lib/appium_lib_core/common/base/bridge/w3c.rb

@@ -3,14 +3,6 @@ module Core
     class Base
       class Bridge
         class W3C < ::Selenium::WebDriver::Remote::W3C::Bridge
-          def self.silence_warnings_redefining(&block)
-            warn_level = $VERBOSE
-            $VERBOSE = nil
-            result = block.call
-            $VERBOSE = warn_level
-            result
-          end
-
           include Device::DeviceLock
           include Device::Keyboard
           include Device::ImeActions
@@ -26,10 +18,6 @@ def self.silence_warnings_redefining(&block)
           include Device::Device
           include Device::TouchActions
 
-          # Used for default duration of each touch actions
-          # Override from 250 milliseconds to 50 milliseconds
-          W3C.silence_warnings_redefining { ::Selenium::WebDriver::PointerActions::DEFAULT_MOVE_DURATION = 0.05 }
-
           def commands(command)
             ::Appium::Core::Commands::W3C::COMMANDS[command]
           end
@@ -48,9 +36,13 @@ def commands(command)
           #     element = @driver.find_element(:id, "some id")
           #     @driver.action.click(element).perform # The `click` is a part of `PointerActions`
           #
-          #     # You can change the kind as the below.
-          #     @driver.action(kind: :mouse).click(element).perform # The `click` is a part of `PointerActions`
-          #
+          def action(async = false)
+            # Used for default duration of each touch actions
+            # Override from 250 milliseconds to 50 milliseconds
+            action_builder = super
+            action_builder.default_move_duration = 0.05
+            action_builder
+          end
 
           # Port from MJSONWP
           def get_timeouts

lib/appium_lib_core/common/command/w3c.rb

@@ -9,10 +9,6 @@ module W3C
             status:                    [:get, 'status'.freeze],
             is_element_displayed:      [:get, 'session/:session_id/element/:id/displayed'.freeze],
 
-            # FIXME: remove after apply https://github.com/SeleniumHQ/selenium/pull/5249
-            # The fix will be included in selenium-3.8.2
-            get_page_source:           [:get, 'session/:session_id/source'.freeze],
-
             get_timeouts:              [:get, 'session/:session_id/timeouts'.freeze],
 
             ## Add OSS commands to W3C commands. We can remove them if we would like to remove them from W3C module.