Add pixel format (#200)

* add pixel_format

* update changelog

Author: KazuCocoa

CHANGELOG.md

@@ -5,6 +5,7 @@ Read `release_notes.md` for commit level details.
 ## [Unreleased]
 
 ### Enhancements
+- Add `pixelFormat` argument in screen record for iOS
 
 ### Bug fixes
 

lib/appium_lib_core/ios/xcuitest/device.rb

@@ -80,6 +80,8 @@ module Device
           #                           is too slow or too fast. Defaults to 10. This can decrease the resulting file size.
           # @param [String] video_scale The scaling value to apply. Read https://trac.ffmpeg.org/wiki/Scaling for possible values.
           #                             No scale is applied by default.
+          # @param [String] pixel_format Output pixel format. Run `ffmpeg -pix_fmts` to list possible values.
+          #                              For Quicktime compatibility, set to "yuv420p" along with videoType: "libx264".
           #
           # @example
           #

lib/appium_lib_core/ios/xcuitest/device/screen.rb

@@ -23,7 +23,7 @@ def self.add_methods
                 # rubocop:disable Metrics/ParameterLists
                 def start_recording_screen(remote_path: nil, user: nil, pass: nil, method: 'PUT', force_restart: nil,
                                            video_type: 'mjpeg', time_limit: '180', video_quality: 'medium',
-                                           video_fps: nil, video_scale: nil)
+                                           video_fps: nil, video_scale: nil, pixel_format: nil)
                   option = ::Appium::Core::Base::Device::ScreenRecord.new(
                     remote_path: remote_path, user: user, pass: pass, method: method, force_restart: force_restart
                   ).upload_option
@@ -34,6 +34,7 @@ def start_recording_screen(remote_path: nil, user: nil, pass: nil, method: 'PUT'
 
                   option[:videoFps] = video_fps unless video_fps.nil?
                   option[:videoScale] = video_scale unless video_scale.nil?
+                  option[:pixelFormat] = pixel_format unless pixel_format.nil?
 
                   execute(:start_recording_screen, {}, { options: option })
                 end

test/unit/ios/device/w3c/commands_test.rb

@@ -63,11 +63,13 @@ def test_start_recording_screen_custom
 
             stub_request(:post, "#{SESSION}/appium/start_recording_screen")
               .with(body: { options: {
-                videoType: 'libx264', timeLimit: '60', videoQuality: 'medium', videoFps: '50', videoScale: '320:240'
+                videoType: 'libx264', timeLimit: '60', videoQuality: 'medium',
+                videoFps: '50', videoScale: '320:240', pixelFormat: 'yuv420p'
               } }.to_json)
               .to_return(headers: HEADER, status: 200, body: { value: ['a'] }.to_json)
 
-            @driver.start_recording_screen video_type: 'libx264', time_limit: '60', video_fps: '50', video_scale: '320:240'
+            @driver.start_recording_screen(video_type: 'libx264', time_limit: '60',
+                                           video_fps: '50', video_scale: '320:240', pixel_format: 'yuv420p')
 
             assert_requested(:post, "#{SESSION}/appium/start_recording_screen", times: 1)
           end