use :app without modifications (#110)

* use :app without modifications

* update changelog

* tweak

Author: KazuCocoa

CHANGELOG.md

@@ -3,6 +3,7 @@ All notable changes to this project will be documented in this file.
 
 ## [Unreleased]
 ### Enhancements
+- Relax the logic of `:app` capability
 
 ### Bug fixes
 

lib/appium_lib_core/driver.rb

@@ -387,12 +387,19 @@ def get_appium_lib_opts(opts)
 
       # @private
       # Path to the .apk, .app or .app.zip.
-      # The path can be local or remote for Sauce.
+      # The path can be local, HTTP/S, Windows Share and other path like `sauce-storage:`.
+      # Use @caps[:app] without modifications if the path isn't HTTP/S or local path.
       def set_app_path
         return unless @caps && @caps[:app] && !@caps[:app].empty?
         return if @caps[:app] =~ URI::DEFAULT_PARSER.make_regexp
 
-        @caps[:app] = File.expand_path(@caps[:app])
+        app_path = File.expand_path(@caps[:app])
+        @caps[:app] = if File.exist? app_path
+                        app_path
+                      else
+                        ::Appium::Logger.info("Use #{@caps[:app]} directly")
+                        @caps[:app]
+                      end
       end
 
       # @private

test/unit/common_test.rb

@@ -81,15 +81,15 @@ def test_create_session_force_mjsonwp_false
         driver
       end
 
-      def test_create_session_force_mjsonwp_with_http_package
+      def test_create_session_force_mjsonwp_with_source_package
         response = {
           status: 0, # To make bridge.dialect == :oss
           value: {
             sessionId: '1234567890',
             capabilities: {
               platformName: :android,
               automationName: 'uiautomator2',
-              app: 'test/functional/app/api.apk',
+              app: 'sauce-storage:test/functional/app/api.apk',
               platformVersion: '7.1.1',
               deviceName: 'Android Emulator',
               appPackage: 'io.appium.android.apis'
@@ -99,7 +99,7 @@ def test_create_session_force_mjsonwp_with_http_package
         http_caps = {
           platformName: :android,
           automationName: 'uiautomator2',
-          app: 'http://example.com/test.apk.zip',
+          app: 'sauce-storage:test/functional/app/api.apk',
           platformVersion: '7.1.1',
           deviceName: 'Android Emulator',
           appPackage: 'io.appium.android.apis'
@@ -119,7 +119,7 @@ def test_create_session_force_mjsonwp_with_http_package
         assert_requested(:post, 'http://127.0.0.1:4723/wd/hub/session', times: 1)
         assert_requested(:post, "#{Mock::SESSION}/timeouts/implicit_wait", body: { ms: 20_000 }.to_json, times: 1)
 
-        assert_equal 'http://example.com/test.apk.zip', core.caps[:app]
+        assert_equal 'sauce-storage:test/functional/app/api.apk', core.caps[:app]
       end
 
       def test_create_session_w3c