Skip to content

Commit e304e54

Browse files
committed
add teardown
1 parent 319d0f8 commit e304e54

File tree

5 files changed

+13
-8
lines changed

5 files changed

+13
-8
lines changed

test/functional/android/android/image_comparison_test.rb

-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ def setup
1212

1313
def teardown
1414
save_reports(@driver)
15-
@@core.quit_driver
1615
end
1716

1817
def test_image_comparison_match_result

test/functional/android/android/mjpeg_server_test.rb

+5-4
Original file line numberDiff line numberDiff line change
@@ -7,21 +7,22 @@ module Android
77
class MjpegServerTest < AppiumLibCoreTest::Function::TestCase
88
def setup
99
@@core ||= ::Appium::Core.for(Caps.android)
10-
@@driver ||= @@core.start_driver
10+
@driver = @@core.start_driver
1111
end
1212

1313
def teardown
1414
save_reports(@@driver)
15+
@@core.quit_driver
1516
end
1617

1718
def test_start_recording_screen
1819
to_path = 'recorded_file_android.mp4'
1920
File.delete to_path if File.exist? to_path
2021

21-
@@driver.start_recording_screen time_limit: '2'
22-
@@driver.find_element(:accessibility_id, 'App').click
22+
@driver.start_recording_screen time_limit: '2'
23+
@driver.find_element(:accessibility_id, 'App').click
2324
sleep 2 # second
24-
@@driver.stop_and_save_recording_screen to_path
25+
@driver.stop_and_save_recording_screen to_path
2526
assert File.exist? to_path
2627
end
2728
end

test/functional/android/patch_test.rb

+1
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ def setup
1111

1212
def teardown
1313
save_reports(@driver)
14+
@driver.quit
1415
end
1516

1617
def test_method_missing_attributes

test/functional/android/webdriver/device_test.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ def test_accept_alert
9999
# assert @driver.switch_to.alert.dismiss
100100
@@core.wait { assert_equal 'OK', @driver.find_element(:id, 'android:id/button1').text.upcase }
101101
result = @driver.find_element(:id, 'android:id/button1').click
102-
assert result.nil? || result.empty?
102+
assert result.nil? || result
103103
end
104104

105105
def test_dismiss_alert
@@ -115,7 +115,7 @@ def test_dismiss_alert
115115
# Because the results depends on OS version.
116116
@@core.wait { assert_equal 'CANCEL', @driver.find_element(:id, 'android:id/button2').text.upcase }
117117
result = @driver.find_element(:id, 'android:id/button2').click
118-
assert result.nil? || result.empty?
118+
assert result.nil? || result
119119
end
120120

121121
def test_implicit_wait

test/functional/ios/ios/image_comparison_test.rb

+5-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,11 @@ module Ios
1010
class ImageComparisionTest < AppiumLibCoreTest::Function::TestCase
1111
def setup
1212
@@core ||= ::Appium::Core.for(Caps.ios)
13-
@@driver ||= @@core.start_driver
13+
@driver ||= @@core.start_driver
14+
end
15+
16+
def teardown
17+
save_reports(@driver)
1418
end
1519

1620
def test_image_comparison_match_result

0 commit comments

Comments
 (0)