Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using Gaussian input distributions in the image_data template method? #300

Closed
isurulucky opened this issue Oct 23, 2024 · 3 comments
Closed
Assignees
Labels
question Further information is requested

Comments

@isurulucky
Copy link
Collaborator

Hi,

Cirkit already supports Gaussian input layer [1], however it's not accessible via the image_data template method. I experimented changing the validations in [2] to support Gaussian input distributions, and it seems to work - did not test extensively though. Is there a specific reason not to support Gaussian inputs distributions for images?

Thanks,
Isuru.

[1]. https://github.com/april-tools/cirkit/blob/main/cirkit/symbolic/layers.py#L426
[2]. https://github.com/april-tools/cirkit/blob/main/cirkit/templates/circuit_templates/data.py

@isurulucky isurulucky changed the title Allow using Gaussian input node in the image template? Allow using Gaussian input node in the image_data template method? Oct 23, 2024
@isurulucky isurulucky added the question Further information is requested label Oct 23, 2024
@isurulucky isurulucky changed the title Allow using Gaussian input node in the image_data template method? Allow using Gaussian input distributions in the image_data template method? Oct 23, 2024
@isurulucky
Copy link
Collaborator Author

Added a draft PR which reflects the changes done: #301

@loreloc
Copy link
Member

loreloc commented Oct 29, 2024

Hi Isuru, thanks a lot for reporting this. We plan to merge it for the next cirkit version.

@loreloc loreloc added this to the cirkit 0.2.0 (murmur) milestone Oct 29, 2024
@loreloc loreloc assigned loreloc and isurulucky and unassigned loreloc Oct 29, 2024
@isurulucky
Copy link
Collaborator Author

Closing as the PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants